Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Blue Circular Label has Blue Background #47

Open
kerry-money opened this issue Jul 17, 2018 · 4 comments
Open

Basic Blue Circular Label has Blue Background #47

kerry-money opened this issue Jul 17, 2018 · 4 comments

Comments

@kerry-money
Copy link

kerry-money commented Jul 17, 2018

I notice label has this rule:

.ui.basic.blue.label {
background-color: @basicBackground !important;
color: @blue !important;
border-color: @blue !important;
}

@basicBackground is a variable designed to specify the whole background property - not simply a color (none @white). Therefore, this is an invalid value and it falls back to the blue background.

I believe background-color should simply be set to @white for this rule. I made an override locally, but am thinking to submit a PR for this.

Without new Rule:
without_rule

With new Rule:
with_new_rule

@rayronvictor
Copy link

@basicBackground: none @white;

.ui.basic.blue.label {
background-color: @basicBackground !important;
color: @blue !important;
border-color: @blue !important;
}

I think that background-color: @basicBackground !important; have to be changed to background: @basicBackground !important;

@scottwarren
Copy link

This happens to all colours of basic labels (not just blue)

@co2meal
Copy link

co2meal commented Aug 24, 2018

Someone already created a Pull Request. Hope it merged soon.
Semantic-Org/Semantic-UI#6440

@lubber-de

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants