Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements skill-based poisoning charge limits and weapon coating. #107

Merged

Conversation

EstelMatiazi
Copy link
Collaborator

implements #93

What this change does is add a server setting to add a new form of poisoning to the game, that if set to true will make the maximum amount of poison charges a character can have in a weapon be dependent on their skills with poisoning instead of an arbitrary fixed number based on poison level. It also changes how many charges are added to a weapon to a number based on character skill instead of going automatically to the maximum.

The aim of this is to make poisoning more enjoyable and less maintenance-heavy for users of the skill.

If the new server setting is set to false, then the default system stays in place and nothing is changed.

Copy link
Contributor

@mz1193 mz1193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change and the way it's done looks great. Even if some folks don't like the idea of this, the fact that it's user-configurable should make that a non-issue.

@sosarian-scribe sosarian-scribe merged commit 157b458 into Secrets-of-Sosaria:main Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants