Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IME: Using return key to commit text does not work #123

Open
LPGhatguy opened this issue Dec 1, 2023 · 1 comment
Open

IME: Using return key to commit text does not work #123

LPGhatguy opened this issue Dec 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@LPGhatguy
Copy link
Member

On my system, using the system IME to compose some characters and then hitting return results in the composition buffer being deleted and no text being inserted into the textbox. That's no good. I can still click options in the menu, which works, but it's not ideal.

I think this might be a race condition in our event handling.

@LPGhatguy LPGhatguy added the bug Something isn't working label Dec 1, 2023
@stolen-programmer
Copy link
Contributor

stolen-programmer commented Dec 1, 2023

I found the problem

When typing enter

Calling ctx.input.set_selection(None);

Causing loss of focus and subsequent commit event

https://github.com/SecondHalfGames/yakui/blob/main/crates/yakui-widgets/src/widgets/textbox.rs#L237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants