New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Concrete `Shape` types in constructors? #11

Open

LPGhatguy opened this issue Apr 30, 2024 · 0 comments

Member

LPGhatguy commented Apr 30, 2024

Currently, all of the shapes are constructed with an API that looks like this:

JPC_API bool JPC_FooShapeSettings_Create(const JPC_FooShapeSettings* self, JPC_Shape** outShape, JPC_String** outError);

but I wonder if we should treat this, conceptually, as binding to the constructors of the shape types themselves:

JPC_API bool JPC_FooShape_new(const JPC_FooShapeSettings* settings, JPC_FooShape** outShape, JPC_String** outError);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment