Merge of latest CefSharp master into the NET40 compatible branch

Author: MikeDiuga

.github/FUNDING.yml

@@ -8,6 +8,6 @@
 #community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
 #custom: # Replace with a single custom sponsorship URL
 
-#github: amaitland
-patreon: alexmaitland
+github: amaitland
+#patreon: alexmaitland
 custom: https://paypal.me/AlexMaitland

.github/ISSUE_TEMPLATE/bug_report.md

@@ -17,46 +17,58 @@ So you have a question to ask, where can you look for answers? Read on. Think yo
 - You can see all the `CefSharp` tagged issues on `Stackoverflow`, some useful stuff there : http://stackoverflow.com/questions/tagged/cefsharp
 - You can search the `Gitter Chat Channel` for past questions/conversations, you can search through every discussion from the beginning : https://gitter.im/cefsharp/CefSharp
 
-Still have a question? Great, ask it on `Gitter`. https://gitter.im/cefsharp/CefSharp
+Still have a question? Great, ask it on [Stackoverflow](http://stackoverflow.com/questions/tagged/cefsharp) or [Gitter](https://gitter.im/cefsharp/CefSharp). Larger complex questions should be asked on `Stackoverflow`
 
 **Note: CefSharp is just a wrapper around the Chromium Embedded Project, it's worth searching http://magpcss.org/ceforum/index.php if your problem involves a low level Chromium error message**
 
-We ask that you put in a reasonable amount of effort in searching through the resources listed above. The developers have full time jobs, they have lives, families, the time they have available to contribute this project is a precious resource, make sure you use it wisely! Remember the more time we spend answering the same questions over and over again, less time goes into writing code, adding new features, actually fixing bugs!
+We ask that you put in a reasonable amount of effort in searching through the resources listed above. The developers have full time jobs, they have lives, families, the time they have available to contribute this project is a precious resource, make sure you use it wisely! Remember the more time we spend answering the same questions over and over again, less time goes into writing code, adding new features, actually fixing bugs! 
 
 Still have a question to ask or unsure where to go next? Start with the Gitter Chat room : https://gitter.im/cefsharp/CefSharp
 
---
+Before posting a bug report please take the time to read https://codeblog.jonskeet.uk/2012/11/24/stack-overflow-question-checklist/
+
+---
 ### Bug Report
 Delete this line and everything above, and then fill in the details below.
 
 - **What version of the product are you using?**
-    - What version are you using? Nuget? CI Nuget? build from a branch? If so which branch? Please include the exact version number you are using (no ambiguous statements like `Latest from Nuget`)
-e.g. 57.0.0 or 63.0.0-pre01
-    - Please only create an issue if you can reproduce the problem with the latest version. (If you are using the latest stable release please check to see if there is a newer `-pre` release and test with that also).
+    - What version are you using? Nuget? CI Nuget? build from a branch? If so please link to the relevant commit.
+	- Please include the exact version number you are using e.g. 79.1.360 (no ambiguous statements like `Latest from Nuget`)
+    - Please only create an issue if you can reproduce the problem with version 79.1.360 or greater.
 
 - **What architecture x86 or x64?**
-
+    <x86/x64>
+    
 - **On what operating system?**
-    - Win7, Win 8, Win10, etc?
+    <Win7/Win8.1/Win10>
 
 - **Are you using `WinForms`, `WPF` or `OffScreen`?**
-
+    <WinForms/WPF/OffScreen>
+    
 - **What steps will reproduce the problem?**
-    - Please provide detailed information here, enough for someone else to reprodce your problem.
-    - Please no binary (zip, etc) links, fork the [MinimalExample](https://github.com/cefsharp/CefSharp.MinimalExample) and push your changes to `GitHub`. (Alternatively use a code sharing service list `Gist` or `Pastebin`).
+    - Please provide detailed information here, enough for someone else to reprodce your problem. 
+    - Does the problem reproduce using the [MinimalExample](https://github.com/cefsharp/CefSharp.MinimalExample)?
+    - If code is required to reproduce your problem then please provide one of the following
+      - Fork the [MinimalExample](https://github.com/cefsharp/CefSharp.MinimalExample) and push your changes to `GitHub` (this is the preferred option).
+      - Use a code sharing service list `Gist` or `Pastebin`
+      - Paste your **formatted code as part of this issue** (only do this for small amounts of code and make sure you **format the code so it's reabily**)
+      - Please no binary attachments (zip, 7z, etc), code needs to be easily reviewed in a web browser.
 
 - **What is the expected output? What do you see instead?**
 
 - **Please provide any additional information below.**
     - A stack trace if available, any Exception information.
+      - If you are seeing a crash in `libcef.dll` then please download `libcef.dll.pdb` and place it next to `libcef.dll` to obtain a detailed stack trace, see https://github.com/cefsharp/CefSharp/wiki/Trouble-Shooting#loading-native-symbols-for-easier-diagnosis for details.
 
     - Does the cef log provide any relevant information? (By default there should be a debug.log file in your bin directory)
 
     - Any other background information that's relevant? Are you doing something out of the ordinary? 3rd party controls?
 
-- **Does this problem also occur in the `CEF` Sample Application from http://opensource.spotify.com/cefbuilds/index.html?**
-
-    - To compare with WPF run cefclient --multi-threaded-message-loop --off-screen-rendering-enabled --enable-gpu
-    - To compare with WinForms run cefclient --multi-threaded-message-loop
+- **Does this problem also occur in the `CEF` Sample Application**
+    - Download one of the following:
+	    - For x86 download http://opensource.spotify.com/cefbuilds/cef_binary_79.1.36%2Bg90301bd%2Bchromium-79.0.3945.130_windows32_client.tar.bz2
+	    - For x64 download http://opensource.spotify.com/cefbuilds/cef_binary_79.1.36%2Bg90301bd%2Bchromium-79.0.3945.130_windows64_client.tar.bz2
+	- If you are using WPF/OffScreen run cefclient --multi-threaded-message-loop --off-screen-rendering-enabled --enable-gpu
+    - If you are using WinForms run cefclient --multi-threaded-message-loop
+	- **MAKE SURE TO TEST WITH THE COMMAND LINE ARGS LISTED ABOVE**
     - If you can reproduce the problem with `cefclient` then you'll need to report the bug on https://bitbucket.org/chromiumembedded/cef/overview there is no point opening an issue here. (Make sure you search before opening an issue)
-    - Please include the version you tested with e.g. `cef_binary_3.3029.1611.g44e39a8_windows64_client.tar.bz2`. It's important to you test with the same version that `CefSharp` is based on. Check the release notes to determine the version (https://github.com/cefsharp/CefSharp/releases) or load `chrome://version` in the browser.

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,9 @@
+# https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
+blank_issues_enabled: false
+contact_links:
+  - name: stackoverflow
+    url: http://stackoverflow.com/questions/tagged/cefsharp
+    about: Please ask and answer questions here.
+  - name: Chromium Embedded Framework(CEF) Forum
+    url: https://magpcss.org/ceforum/index.php
+    about: Please ask your non CefSharp specific CEF questions here

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,12 +1,16 @@
 ---
 name: Feature request
-about: Suggest an idea for this project
+about: Suggest an idea for this project, please don't use this template to ask questions, thank you.
 title: Feature Request - My Feature
 labels: feature-request
 assignees: ''
 
 ---
 
+Please ask your questions on https://stackoverflow.com/questions/tagged/cefsharp
+
+---
+
 `CefSharp` is a wrapper around the [Chromium Embedded Framework](https://bitbucket.org/chromiumembedded/cef/overview) in a lot of cases a feature must be added to `CEF` first before it can be used in `CefSharp`. `CEF` has it's own `Feature Request Forum` at https://magpcss.org/ceforum/viewforum.php?f=7
 
 --- 

.github/support.yml

@@ -9,10 +9,13 @@ supportComment: >
   :wave: @{issue-author}, we use the issue tracker exclusively for bug reports
   and feature requests. However, this issue appears to be a support request.
   Please use our support channels to get help with the project.
-  
+  <br/>
   If you have a question, ask it on [StackOverflow](http://stackoverflow.com/questions/tagged/cefsharp) or use [ceforum](http://magpcss.org/ceforum/) (for questions specific to `CEF`).
-  
+  <br/>
   If you are new to `CefSharp` then we suggest you read https://github.com/cefsharp/CefSharp/wiki/General-Usage
+  <br/>
+  If you feel this was closed in error then you **must** edit your original issue and complete the [Bug Report Template](https://github.com/cefsharp/CefSharp/blob/master/.github/ISSUE_TEMPLATE/bug_report.md#bug-report)
+  then post a comment asking for a review.
 
 # Close issues marked as support requests
 close: true

.vsconfig

@@ -0,0 +1,29 @@
+{
+  "version": "1.0",
+  "components": [
+    "Microsoft.VisualStudio.Component.CoreEditor",
+    "Microsoft.VisualStudio.Workload.CoreEditor",
+    "Microsoft.VisualStudio.Component.NuGet",
+    "Microsoft.Net.Component.4.6.1.TargetingPack",
+    "Microsoft.VisualStudio.Component.Roslyn.Compiler",
+    "Microsoft.VisualStudio.Component.Roslyn.LanguageServices",
+    "Microsoft.Net.ComponentGroup.DevelopmentPrerequisites",
+    "Microsoft.Component.MSBuild",
+    "Microsoft.VisualStudio.Component.ManagedDesktop.Core",
+    "Microsoft.Net.Component.4.5.2.TargetingPack",
+    "Microsoft.VisualStudio.Component.IntelliCode",
+    "Microsoft.Net.ComponentGroup.TargetingPacks.Common",
+    "Microsoft.VisualStudio.Component.Debugger.JustInTime",
+    "Microsoft.VisualStudio.Component.VC.CoreIde",
+    "Microsoft.VisualStudio.Component.Windows10SDK",
+    "Microsoft.VisualStudio.Component.VC.Tools.x86.x64",
+    "Microsoft.VisualStudio.Component.ManagedDesktop.Prerequisites",
+    "Microsoft.ComponentGroup.Blend",
+    "Microsoft.VisualStudio.Workload.ManagedDesktop",
+    "Microsoft.VisualStudio.Component.VC.Redist.14.Latest",
+    "Microsoft.VisualStudio.ComponentGroup.NativeDesktop.Core",
+    "Microsoft.VisualStudio.Component.VC.CLI.Support",
+    "Microsoft.VisualStudio.Component.Windows10SDK.18362",
+    "Microsoft.VisualStudio.Workload.NativeDesktop"
+  ]
+}

CefSharp.BrowserSubprocess.Core/BrowserSubprocessExecutable.h

@@ -0,0 +1,116 @@
+// Copyright © 2019 The CefSharp Authors. All rights reserved.
+//
+// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
+
+#pragma once
+
+#include "Stdafx.h"
+
+#include "SubProcess.h"
+#include "WcfEnabledSubProcess.h"
+
+using namespace System;
+using namespace CefSharp::Internals;
+
+namespace CefSharp
+{
+    namespace BrowserSubprocess
+    {
+        /// <summary>
+        /// BrowserSubprocessExecutable provides the fundimental browser process handling for
+        /// CefSharp.BrowserSubprocess.exe and can be used to self host the BrowserSubProcess in your
+        /// existing application (preferred approach for .Net Core).
+        /// </summary>
+        public ref class BrowserSubprocessExecutable
+        {
+        public:
+            BrowserSubprocessExecutable()
+            {
+
+            }
+
+            /// <summary>
+            /// This function should be called from the application entry point function (typically Program.Main)
+            /// to execute a secondary process e.g. gpu, plugin, renderer, utility
+            /// It can be used to run secondary processes (BrowserSubProcess) from your main applications executable
+            /// or from a separate executable specified by the CefSettings.BrowserSubprocessPath value.
+            /// CefSharp defaults to using the latter approach, a default implementation (CefSharp.BrowserSubProcess.exe) is
+            /// supplied, see https://github.com/cefsharp/CefSharp/wiki/General-Usage#processes for more details.
+            /// </summary>
+            /// <param name="args">command line args</param>
+            /// <returns>
+            /// If called for the browser process (identified by no "type" command-line value) it will return immediately
+            /// with a value of -1. If called for a recognized secondary process it will block until the process should exit
+            /// and then return the process exit code.
+            /// </returns
+            int Main(IEnumerable<String^>^ args)
+            {
+                return Main(args, nullptr);
+            }
+
+            /// <summary>
+            /// This function should be called from the application entry point function (typically Program.Main)
+            /// to execute a secondary process e.g. gpu, plugin, renderer, utility
+            /// It can be used to run secondary processes (BrowserSubProcess) from your main applications executable
+            /// or from a separate executable specified by the CefSettings.BrowserSubprocessPath value.
+            /// CefSharp defaults to using the latter approach, a default implementation (CefSharp.BrowserSubProcess.exe) is
+            /// supplied, see https://github.com/cefsharp/CefSharp/wiki/General-Usage#processes for more details.
+            /// </summary>
+            /// <param name="args">command line args</param>
+            /// <param name="handler">An option IRenderProcessHandler implementation, use null if no handler is required</param>
+            /// <returns>
+            /// If called for the browser process (identified by no "type" command-line value) it will return immediately
+            /// with a value of -1. If called for a recognized secondary process it will block until the process should exit
+            /// and then return the process exit code.
+            /// </returns>
+            int Main(IEnumerable<String^>^ args, IRenderProcessHandler^ handler)
+            {
+                auto type = CommandLineArgsParser::GetArgumentValue(args, CefSharpArguments::SubProcessTypeArgument);
+
+                if (String::IsNullOrEmpty(type))
+                {
+                    //If --type param missing from command line CEF/Chromium assums
+                    //this is the main process (as all subprocesses must have a type param).
+                    //Return -1 to indicate this behaviour.
+                    return -1;
+                }
+
+                auto parentProcessId = -1;
+
+                // The Crashpad Handler doesn't have any HostProcessIdArgument, so we must not try to
+                // parse it lest we want an ArgumentNullException.
+                if (type != "crashpad-handler")
+                {
+                    parentProcessId = int::Parse(CommandLineArgsParser::GetArgumentValue(args, CefSharpArguments::HostProcessIdArgument));
+                    if (CommandLineArgsParser::HasArgument(args, CefSharpArguments::ExitIfParentProcessClosed))
+                    {
+                        ParentProcessMonitor::StartMonitorTask(parentProcessId);
+                    }
+                }
+
+                // Use our custom subProcess provides features like EvaluateJavascript
+                if (type == "renderer")
+                {
+                    auto subProcess = GetSubprocess(args, parentProcessId, handler);
+
+                    try
+                    {
+                        return subProcess->Run();
+                    }
+                    finally
+                    {
+                        delete subProcess;
+                    }
+                }
+
+                return SubProcess::ExecuteProcess(args);
+            }
+
+        protected:
+            virtual SubProcess^ GetSubprocess(IEnumerable<String^>^ args, int parentProcessId, IRenderProcessHandler^ handler)
+            {
+                return gcnew SubProcess(handler, args);
+            }
+        };
+    }
+}

CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp

@@ -241,15 +241,15 @@ namespace CefSharp
         auto frames = CefListValue::Create();
         for (auto i = 0; i < stackTrace->GetFrameCount(); i++)
         {
-            auto frame = CefListValue::Create();
+            auto stackTraceFrame = CefListValue::Create();
             auto frameArg = stackTrace->GetFrame(i);
 
-            frame->SetString(0, frameArg->GetFunctionName());
-            frame->SetInt(1, frameArg->GetLineNumber());
-            frame->SetInt(2, frameArg->GetColumn());
-            frame->SetString(3, frameArg->GetScriptNameOrSourceURL());
+            stackTraceFrame->SetString(0, frameArg->GetFunctionName());
+            stackTraceFrame->SetInt(1, frameArg->GetLineNumber());
+            stackTraceFrame->SetInt(2, frameArg->GetColumn());
+            stackTraceFrame->SetString(3, frameArg->GetScriptNameOrSourceURL());
 
-            frames->SetList(i, frame);
+            frames->SetList(i, stackTraceFrame);
         }
 
         list->SetList(1, frames);
@@ -579,8 +579,8 @@ namespace CefSharp
                             for (auto i = 0; i < javascriptObjects->Count; i++)
                             {
                                 auto dict = CefDictionaryValue::Create();
-                                auto name = javascriptObjects[i]->JavascriptName;
-                                dict->SetString("Name", StringUtils::ToNative(name));
+                                auto objectName = javascriptObjects[i]->JavascriptName;
+                                dict->SetString("Name", StringUtils::ToNative(objectName));
                                 dict->SetBool("IsCached", false);
                                 dict->SetBool("AlreadyBound", false);
 

CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.vcxproj

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <Import Project="..\packages\cef.sdk.76.1.9\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.76.1.9\build\cef.sdk.props')" />
+  <Import Project="..\packages\cef.sdk.79.1.36\build\cef.sdk.props" Condition="Exists('..\packages\cef.sdk.79.1.36\build\cef.sdk.props')" />
   <ItemGroup Label="ProjectConfigurations">
     <ProjectConfiguration Include="Debug-Net40|Win32">
       <Configuration>Debug-Net40</Configuration>
@@ -321,13 +321,15 @@
     <ClInclude Include="..\CefSharp.Core\Internals\Serialization\Primitives.h" />
     <ClInclude Include="..\CefSharp.Core\Internals\StringUtils.h" />
     <ClInclude Include="BindObjectAsyncHandler.h" />
+    <ClCompile Include="BrowserSubprocessExecutable.h" />
     <ClInclude Include="SubProcessApp.h" />
     <ClInclude Include="Async\JavascriptAsyncMethodCallback.h" />
     <ClInclude Include="Async\JavascriptAsyncMethodHandler.h" />
     <ClInclude Include="Async\JavascriptAsyncMethodWrapper.h" />
     <ClInclude Include="Async\JavascriptAsyncObjectWrapper.h" />
     <ClInclude Include="CefAppUnmanagedWrapper.h" />
     <ClInclude Include="JavascriptPostMessageHandler.h" />
+    <ClCompile Include="WcfBrowserSubprocessExecutable.h" />
     <ClInclude Include="Wrapper\Frame.h" />
     <ClInclude Include="Wrapper\Browser.h" />
     <ClInclude Include="Wrapper\V8Context.h" />

CefSharp.BrowserSubprocess.Core/CefSharp.BrowserSubprocess.Core.vcxproj.filters

@@ -181,6 +181,12 @@
     <ClCompile Include="Wrapper\Browser.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
+    <ClCompile Include="WcfBrowserSubprocessExecutable.h">
+      <Filter>Header Files</Filter>
+    </ClCompile>
+    <ClCompile Include="BrowserSubprocessExecutable.h">
+      <Filter>Header Files</Filter>
+    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <ResourceCompile Include="Resource.rc" />

CefSharp.BrowserSubprocess.Core/RegisterBoundObjectHandler.h

@@ -42,8 +42,6 @@ namespace CefSharp
                 {
                     try
                     {
-                        auto global = context->GetGlobal();
-
                         if (name == kIsObjectCached || name == kIsObjectCachedCamelCase)
                         {
                             if (arguments.size() == 0 || arguments.size() > 1)