Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Option for Food Search #76

Open
MasterOfTheTiger opened this issue May 14, 2020 · 5 comments
Open

Language Option for Food Search #76

MasterOfTheTiger opened this issue May 14, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@MasterOfTheTiger
Copy link

When I search for food, I am greeted with options in French. I do not see any option to change the language, but I do see that the API you use does support English.

Did I miss something or is there no option to change languages from within the app?

@Kamuno Kamuno added the enhancement New feature or request label May 14, 2020
@Kamuno
Copy link
Member

Kamuno commented May 14, 2020

I just checked and it seems the App is either using german or "world" for the api.
It would indeed be nice if you could choose your country or if it atleast would be chosen for you according to your device setting.

These are the supported countries:
https://world.openfoodfacts.org/data/taxonomies/countries.json

@MasterOfTheTiger
Copy link
Author

I was pretty sure I saw French (but I don't want to embarass myself too much so I'll check again).

Kamuno added a commit that referenced this issue May 14, 2020
Added temporary fix to #76. It's missing a propper check if the country code is supported.
Allowed calls on main thread for now to improve stability and reduce crashes. When the database call structure has been redone, this should be switched off again.
Fixes #75, Fixes #65 (fixed with the key generation change)
@Kamuno
Copy link
Member

Kamuno commented Jun 4, 2020

  • Add option to search in world database if no results in local database.
  • Add option in settings to choose country

@christianfl
Copy link

christianfl commented May 18, 2021

* Add option to search in world database if no results in local database.

* Add option in settings to choose country

There's unfortunately another case: The country specific search can find some product(s) but not all so that the world search shows more options.

Edit: Wouldn't it be better to just use "world" until any manual exclusive country setting is there? This would be very easy to change just within /app/src/main/java/org/secuso/privacyfriendlyfoodtracker/network/ApiManager.java

private ProductApiService createProductApiService() {
  String languageCode = "world";
  productApiService = createProductApiService(languageCode);
  
  return productApiService;
}

Otherwise there are many products missing.

@anddam
Copy link

anddam commented Sep 26, 2021

Edit: Wouldn't it be better to just use "world" until any manual exclusive country setting is there? This would be very easy to change just within /app/src/main/java/org/secuso/privacyfriendlyfoodtracker/network/ApiManager.java

Yes it would. I spoke about this on OFF slack channel a few months ago and got confirmation.

I am surprised this is still an open issue, this makes the application unusable for those affected by the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants