Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control part drawing was wrong in some cases. #58

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jmbau
Copy link
Collaborator

@jmbau jmbau commented Aug 1, 2024

When trying to add rudders to YF-22, I saw that they don't rotate around the right axis. This is because part angle modification was only added to part placement rotations: it works fine when control part rotation axis is on a vertical or horizontal plane, but don't work when it is not.
Now, control part is firstly move to its position, then only after that modification angle is applied to the moved part, which solves issue.
I checked, existing helicopters are not affected by this code modification.

@hsanjuan hsanjuan merged commit ec3e300 into master Sep 3, 2024
1 check passed
@hsanjuan hsanjuan deleted the control_part_drawing_modification branch September 3, 2024 22:22
@hsanjuan
Copy link
Member

hsanjuan commented Sep 3, 2024

👏 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants