Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references of Twitter to X #504

Closed
wants to merge 1 commit into from

Conversation

DNin01
Copy link
Member

@DNin01 DNin01 commented Nov 14, 2024

Resolves #503

Changed references to the Twitter brand to X, to stay up to date.

I know, I know! A lot of us don't like X, but consistency matters, and X doesn't seem to be going away anytime soon.

@DNin01 DNin01 requested a review from Hans5958 November 14, 2024 02:35
@Secret-chest
Copy link
Contributor

You should at least use X/Twitter

@@ -20,7 +20,7 @@ <h2>Alternatives</h2>
<li>Create a issue on <a href="https://github.com/ScratchAddons/ScratchAddons/issues" rel="noopener">the repository</a>.</li>
<li>Create a post on <a href="https://github.com/ScratchAddons/ScratchAddons/discussions" rel="noopener">our Discussions tab</a></li>
<li>Send a message on <a href="https://discord.gg/R5NBqwMjNc" rel="noopener">our Discord server</a></li>
<li>Contact one of the contributors on Discord, Twitter, or other methods</li>
<li>Contact one of the contributors on Discord, X, or other methods</li>
Copy link
Member Author

@DNin01 DNin01 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should at least use X/Twitter

Like this?

Suggested change
<li>Contact one of the contributors on Discord, X, or other methods</li>
<li>Contact one of the contributors on Discord, X/Twitter, or other methods</li>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Contact one of the contributors on Discord, X, or other methods</li>
<li>Contact one of the contributors on Discord, X (Twitter), or other methods</li>

@DNin01
Copy link
Member Author

DNin01 commented Nov 17, 2024

@WorldLanguages, would you rather remove the links and references to Twitter/X entirely?

@WorldLanguages
Copy link
Member

@WorldLanguages, would you rather remove the links and references to Twitter/X entirely?

I don't think so

@DNin01
Copy link
Member Author

DNin01 commented Nov 18, 2024

@WorldLanguages, would you rather remove the links and references to Twitter/X entirely?

I don't think so

So should we change it to X or leave it as Twitter?

If not, I think a more reasonable choice to make would be to leave Twitter/X completely. Having a link to Twitter (now X) is still promotion for X, despite us referencing it as Twitter, and continuing to use X implies that we support that platform.

@DNin01
Copy link
Member Author

DNin01 commented Dec 3, 2024

@WorldLanguages Should we change it, remove it, or keep it as is?

@WorldLanguages
Copy link
Member

@DNin01 I would keep it as "Twitter" for 1 more year 😄 and revisit it

@DNin01
Copy link
Member Author

DNin01 commented Dec 6, 2024

Alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update the Twitter logo
4 participants