diff --git a/.cspell/custom-words.txt b/.cspell/custom-words.txt index 146aa493d9a..3e1c2f9ee5f 100644 --- a/.cspell/custom-words.txt +++ b/.cspell/custom-words.txt @@ -83,6 +83,7 @@ drawio duckpy dvipdfmx EINVAL +endup enmascarado excrepr executemany @@ -198,6 +199,7 @@ linuxsys Ljava llabel localdb +localns LowLevel lproj lsregister @@ -214,6 +216,7 @@ metaraw miniserde mnone moff +monomorphization mountpoint MountPoints msgid @@ -223,12 +226,15 @@ multibytes mycapacitorapp myclass Nanos +ntns +ntics napi newsfragment newsfragments NiƱo nmspc nocapture +noserver NONCEBYTES noopener noreferrer @@ -247,6 +253,7 @@ oneofschema Onone OpsLimit ORGANIZATIONID +orgid oscrypt oscrypto OSXFUSE diff --git a/oxidation/libparsec/crates/client/src/certificates_ops.rs b/oxidation/libparsec/crates/client/src/certificates_ops.rs index 5bfa37ad6b8..0c32efb3ed4 100644 --- a/oxidation/libparsec/crates/client/src/certificates_ops.rs +++ b/oxidation/libparsec/crates/client/src/certificates_ops.rs @@ -148,7 +148,7 @@ impl CertificatesOps { // supposed to be added in a strictly causal order, hence // we are supposed to have already added all the certificates // needed to validate this one. And if that's not the case - // it's suspicious and error sould be raised ! + // it's suspicious and error should be raised ! return Err(InvalidCertificateError::UnknownAuthor { hint: $unsecure.hint(), author: $author.clone(), diff --git a/oxidation/libparsec/crates/client/src/event_bus.rs b/oxidation/libparsec/crates/client/src/event_bus.rs index 70bd95f29b1..08a7baea1a8 100644 --- a/oxidation/libparsec/crates/client/src/event_bus.rs +++ b/oxidation/libparsec/crates/client/src/event_bus.rs @@ -91,7 +91,7 @@ macro_rules! impl_broadcastable { // th comparison is done on the fat pointer (i.e. both the pointer // on the data and the pointer on the vtable). // see: https://github.com/rust-lang/rust/issues/106447 - // So the solution is to manualy transform the fat pointer into + // So the solution is to manually transform the fat pointer into // a thin one (i.e. the pointer on the data) let e_fatptr: *const _ = e.as_ref(); let e_thinptr = e_fatptr as *const () as usize; diff --git a/oxidation/libparsec/crates/client_connection/src/testbed.rs b/oxidation/libparsec/crates/client_connection/src/testbed.rs index 0cc5c5b919d..b6556b2e448 100644 --- a/oxidation/libparsec/crates/client_connection/src/testbed.rs +++ b/oxidation/libparsec/crates/client_connection/src/testbed.rs @@ -55,14 +55,14 @@ impl ResponseMock { } // We want the testbed to return an async function pointer to mock client requests. -// In Rust this is increadibly cumbersome to do: +// In Rust this is incredibly cumbersome to do: // - `*SendHookFn` can have multiple implementation, so it must be boxed // - async function is considered as a regular function that return a future... // - ...future which must be wrapped in a pinned box given it can have multiple // implementations // - `*SendHookFn` is going to be stored in structure that use `Debug`, so // it must implement those traits itself. -// Due to Rust's orphan rule, the only way to do that is to indroduce our own trait +// Due to Rust's orphan rule, the only way to do that is to introduce our own trait // `*SendHookFnT` on which we implement `Debug`. // From that, `SendHookFnT` must be auto-implemented on each closure that respect // the send hook signature. diff --git a/oxidation/libparsec/crates/platform_storage2/src/native/certificates.rs b/oxidation/libparsec/crates/platform_storage2/src/native/certificates.rs index 042addd8f00..c910ff4bf23 100644 --- a/oxidation/libparsec/crates/platform_storage2/src/native/certificates.rs +++ b/oxidation/libparsec/crates/platform_storage2/src/native/certificates.rs @@ -379,7 +379,7 @@ impl CertificatesStorage { .await } - /// We never remove nor replace certificates, as a certifacet is immutable (a new + /// We never remove nor replace certificates, as a certificate is immutable (a new /// certificate should be issued to represent a modification, e.g. for realm role) /// So if the server start sending certificates that doesn't match with the one we /// currently have stored, it means somebody is acting fishy ! @@ -395,7 +395,7 @@ impl CertificatesStorage { let _update_guard = self.lock_update.lock().await; // It's unlikely the certificate is already present, so we don't check for it - // existance in cache and rely instead on the unique violation error from SQlite + // existence in cache and rely instead on the unique violation error from SQlite self.db .exec(move |conn| { conn.immediate_transaction(|conn| { diff --git a/oxidation/libparsec/crates/platform_storage2/src/native/model.rs b/oxidation/libparsec/crates/platform_storage2/src/native/model.rs index d47624a4d2e..ffe604c3a13 100644 --- a/oxidation/libparsec/crates/platform_storage2/src/native/model.rs +++ b/oxidation/libparsec/crates/platform_storage2/src/native/model.rs @@ -118,7 +118,7 @@ table! { // The format for `hint` is ": :..." // For instance: // - User & revoked user certificates: "user_id:2199bb7d21ec4988825db6bcf9d7a43e" - // - Realm role certficate: "user_id:2199bb7d21ec4988825db6bcf9d7a43e realm_id:dcf41c521cae4682a4cf29302e2af1b6" + // - Realm role certificate: "user_id:2199bb7d21ec4988825db6bcf9d7a43e realm_id:dcf41c521cae4682a4cf29302e2af1b6" // - Device certificate: "user_id:2199bb7d21ec4988825db6bcf9d7a43e device_name:78c339d140664e909961c05b4d9add4c" // - sequester service certificate: "service_id:1fc552746e1e4a27aa9fd2aa9c8c95cc" // - Sequester authority: "" (nothing to index) diff --git a/oxidation/libparsec/crates/platform_storage2/src/native/sql/create-certificates-table.sql b/oxidation/libparsec/crates/platform_storage2/src/native/sql/create-certificates-table.sql index bc2f1727868..b1c3e3ef37b 100644 --- a/oxidation/libparsec/crates/platform_storage2/src/native/sql/create-certificates-table.sql +++ b/oxidation/libparsec/crates/platform_storage2/src/native/sql/create-certificates-table.sql @@ -17,7 +17,7 @@ CREATE TABLE IF NOT EXISTS certificates ( -- The format for `hint` is ": :..." -- For instance: -- - User & revoked user certificates: "user_id:2199bb7d21ec4988825db6bcf9d7a43e" - -- - Realm role certficate: "user_id:2199bb7d21ec4988825db6bcf9d7a43e realm_id:dcf41c521cae4682a4cf29302e2af1b6" + -- - Realm role certificate: "user_id:2199bb7d21ec4988825db6bcf9d7a43e realm_id:dcf41c521cae4682a4cf29302e2af1b6" -- - Device certificate: "user_id:2199bb7d21ec4988825db6bcf9d7a43e device_name:78c339d140664e909961c05b4d9add4c" -- - sequester service certificate: "service_id:1fc552746e1e4a27aa9fd2aa9c8c95cc" -- - Sequester authority: "" (nothing to index) diff --git a/oxidation/libparsec/crates/protocol/schema/authenticated_cmds/events_listen.json5 b/oxidation/libparsec/crates/protocol/schema/authenticated_cmds/events_listen.json5 index 888712f8cd2..94338684d6a 100644 --- a/oxidation/libparsec/crates/protocol/schema/authenticated_cmds/events_listen.json5 +++ b/oxidation/libparsec/crates/protocol/schema/authenticated_cmds/events_listen.json5 @@ -14,7 +14,7 @@ "unit": "APIEvent" }, { - // Returned if the command is used through the regualr rpc route + // Returned if the command is used through the regular rpc route // instead of the SSE one "status": "not_available" } diff --git a/oxidation/libparsec/crates/serialization_format/tests/common/libparsec_types_mock.rs b/oxidation/libparsec/crates/serialization_format/tests/common/libparsec_types_mock.rs index 76e5252649a..e8c9508a5e1 100644 --- a/oxidation/libparsec/crates/serialization_format/tests/common/libparsec_types_mock.rs +++ b/oxidation/libparsec/crates/serialization_format/tests/common/libparsec_types_mock.rs @@ -3,7 +3,7 @@ // We don't want to have this crate depend on `libparsec_types` for it test // given `libparsec_types` itself uses this crate... hence in case of bug in // this crate we wouldn't be able to use the tests ! -// So here we simulate `liparsec_types` by implementing the bare minimum that +// So here we simulate `libparsec_types` by implementing the bare minimum that // our macros need. pub type Integer = i64; diff --git a/oxidation/libparsec/crates/testbed/tests/unit/testbed.rs b/oxidation/libparsec/crates/testbed/tests/unit/testbed.rs index 7634c90f232..b95cecc9419 100644 --- a/oxidation/libparsec/crates/testbed/tests/unit/testbed.rs +++ b/oxidation/libparsec/crates/testbed/tests/unit/testbed.rs @@ -15,7 +15,7 @@ pub fn generate_stability() { } #[test] -pub fn get_template_statibility() { +pub fn get_template_stability() { let a1 = get_template("minimal"); let a2 = get_template("minimal"); assert!(Arc::ptr_eq(&a1, &a2)); diff --git a/oxidation/libparsec/crates/types/src/certif.rs b/oxidation/libparsec/crates/types/src/certif.rs index 96b78a840df..4445dcf57cf 100644 --- a/oxidation/libparsec/crates/types/src/certif.rs +++ b/oxidation/libparsec/crates/types/src/certif.rs @@ -80,7 +80,7 @@ fn check_author_allow_root( } pub enum UnsecureSkipValidationReason { - // Certificate must have been valided prior to being added to the local storage, + // Certificate must have been validated prior to being added to the local storage, // on top of that the certificate are store encrypted so they cannot be tempered. // Hence it's safe not to validate the certificate when reading thom from the // local storage. diff --git a/parsec/api/protocol/__init__.py b/parsec/api/protocol/__init__.py index 6e782b58da6..8a185c84c70 100644 --- a/parsec/api/protocol/__init__.py +++ b/parsec/api/protocol/__init__.py @@ -27,7 +27,7 @@ unpackb, ) -# TODO: Tests should use the json shema instead of this +# TODO: Tests should use the json schema instead of this from parsec.api.protocol.cmds import ( ANONYMOUS_CMDS, AUTHENTICATED_CMDS, diff --git a/parsec/backend/events.py b/parsec/backend/events.py index 6b9a96f3d1c..290d62e7029 100644 --- a/parsec/backend/events.py +++ b/parsec/backend/events.py @@ -268,7 +268,7 @@ def _on_event( _on_event, # type: ignore ) - # We must do that here to be righ after even bus connection, but before any + # We must do that here to be right after even bus connection, but before any # async operation, otherwise a concurrent event may be handled by the registered # callbacks and also appear in the cache (and in the end we will send to the # client this event twice !) diff --git a/parsec/backend/memory/user.py b/parsec/backend/memory/user.py index 0b03fc29dea..604fd38143d 100644 --- a/parsec/backend/memory/user.py +++ b/parsec/backend/memory/user.py @@ -398,7 +398,7 @@ async def update_user( if user.revoked_on or user.profile == new_profile: raise UserAlreadyExistsError() - # TODO: check all user/device/realm roles certifiactes creation date against `updated_on` + # TODO: check all user/device/realm roles certificates creation date against `updated_on` # and raise `UserRequireGreaterTimestampError` # TODO: check the last vlob the updated user has uploaded is not posterior to diff --git a/tests/core/backend_connection/test_authenticated_cmds.py b/tests/core/backend_connection/test_authenticated_cmds.py index 149eda08293..204323d1b12 100644 --- a/tests/core/backend_connection/test_authenticated_cmds.py +++ b/tests/core/backend_connection/test_authenticated_cmds.py @@ -135,7 +135,7 @@ async def test_handshake_revoked_device(running_backend, alice, bob): @pytest.mark.trio async def test_organization_expired(running_backend, alice, expiredorg): - # Organization expiration is checked before user existance, so we can + # Organization expiration is checked before user existence, so we can # use a dummy user for this test expiredorg_alice = LocalDevice.generate_new_device( organization_addr=expiredorg.addr,