replace "return 0" with explicit "return SUCCESS"

Author: alyst

examples/cvode_Roberts_dns.jl

@@ -72,7 +72,7 @@ function Jac(N, t, y, fy, Jptr, user_data,
     J[2,2] = -1.0e4*y[3] - 6.0e7*y[2]
     J[2,3] = -1.0e4*y[2]
     J[3,2] = 6.0e7*y[2]
-    return Int32(0)
+    return Sundials.CV_SUCCESS
 end
 
 neq = 3

examples/cvode_Roberts_simplified.jl

@@ -6,7 +6,7 @@ function f(t, y, ydot)
     ydot[1] = -0.04*y[1] + 1.0e4*y[2]*y[3]
     ydot[3] = 3.0e7*y[2]*y[2]
     ydot[2] = -ydot[1] - ydot[3]
-    return(Int32(0))
+    return Sundials.CV_SUCCESS
 end
 t = [0.0; 4 * logspace(-1., 7., 9)]
 res = Sundials.cvode(f, [1.0, 0.0, 0.0], t)

examples/ida_Cable.jl

@@ -65,7 +65,7 @@ function cableres(t, u, up, r)
 
     end
 
-    return (0)
+    return Sundials.CV_SUCCESS
 end
 
 
@@ -99,21 +99,21 @@ function idabandsol(f::Function, y0::Vector{Float64}, yp0::Vector{Float64},
     flag = Sundials.IDAInit(mem, cfunction(Sundials.idasolfun, Int32,
                                            (Sundials.realtype, Sundials.N_Vector, Sundials.N_Vector, Sundials.N_Vector, Ref{Function})),
                             t[1], nvector(y0), nvector(yp0))
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     flag = Sundials.IDASetId(mem,nvector(id))
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     flag = Sundials.IDASetUserData(mem, f)
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     flag = Sundials.IDASStolerances(mem, reltol, abstol)
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     mu = xsteps-1
     ml = xsteps-1
     flag = Sundials.IDABand(mem, neq, mu, ml)
     ##flag = Sundials.IDADense(mem, neq)
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     rtest = zeros(neq)
     flag = Sundials.IDACalcIC(mem, Sundials.IDA_YA_YDP_INIT, t[2])
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     yres = zeros(length(t), length(y0))
     ypres = zeros(length(t), length(y0))
     yres[1,:] = y0

examples/ida_Heat2D.jl

@@ -56,8 +56,8 @@ function heatres(t, u, up, r)
                                         4.0 * u[loc])
         end
     end
-    
-    return (0)
+
+    return Sundials.CV_SUCCESS
 end
 
 
@@ -117,22 +117,22 @@ function idabandsol(f::Function, y0::Vector{Float64}, yp0::Vector{Float64},
     flag = Sundials.IDAInit(mem, cfunction(Sundials.idasolfun, Int32,
                                            (Sundials.realtype, Sundials.N_Vector, Sundials.N_Vector, Sundials.N_Vector, Ref{Function})),
                             t[1], nvector(y0), nvector(yp0))
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     flag = Sundials.IDASetId(mem,nvector(id))
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     flag = Sundials.IDASetConstraints(mem,nvector(constraints))
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     flag = Sundials.IDASetUserData(mem, f)
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     flag = Sundials.IDASStolerances(mem, reltol, abstol)
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     mu = MGRID
     ml = MGRID
     flag = Sundials.IDABand(mem, neq, mu, ml)
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     rtest = zeros(neq)
     flag = Sundials.IDACalcIC(mem, Sundials.IDA_YA_YDP_INIT, t[2])
-    assert(flag == 0)
+    assert(flag == Sundials.CV_SUCCESS)
     yres = zeros(length(t), length(y0))
     ypres = zeros(length(t), length(y0))
     yres[1,:] = y0

examples/ida_Roberts_dns.jl

@@ -43,7 +43,7 @@ function resrob(tres, yy, yp, rr, user_data)
     rval[2]  = -rval[1] - 3.0e7*yval[2]*yval[2] - ypval[2]
     rval[1] -=  ypval[1]
     rval[3]  =  yval[1] + yval[2] + yval[3] - 1.0
-    return Cint(0)   # indicates normal return
+    return Sundials.IDA_SUCCESS
 end
 
 ## Root function routine. Compute functions g_i(t,y) for i = 0,1.
@@ -52,7 +52,7 @@ function grob(t, yy, yp, gout, user_data)
     gval = Sundials.asarray(gout, (2,))
     gval[1] = yval[1] - 0.0001
     gval[2] = yval[3] - 0.01
-    return Cint(0)   # indicates normal return
+    return Sundials.IDA_SUCCESS
 end
 
 ## Define the Jacobian function. BROKEN - JJ is wrong
@@ -69,7 +69,7 @@ function jacrob(Neq, tt, cj, yy, yp, resvec,
     JJ[1,3] = 1.0e4*yval[2]
     JJ[2,3] = -1.0e4*yval[2]
     JJ[3,3] = 1.0
-    return Cint(0)   # indicates normal return
+    return Sundials.IDA_SUCCESS
 end
 
 neq = 3

examples/kinsol_mkinTest.jl

@@ -18,7 +18,7 @@ function sysfn(y_in, fy_in, a_in)
     fy = Sundials.asarray(fy_in)
     fy[1] = y[1]^2 + y[2]^2 - 1.0
     fy[2] = y[2] - y[1]^2
-    return Cint(0)   # indicates normal return
+    return Sundials.KIN_SUCCESS
 end
 
 ## Initialize problem