Skip to content

Commit 99411d5

Browse files
committed
replace "return 0" with explicit "return SUCCESS"
1 parent 628e1ec commit 99411d5

6 files changed

+22
-22
lines changed

examples/cvode_Roberts_dns.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function Jac(N, t, y, fy, Jptr, user_data,
7272
J[2,2] = -1.0e4*y[3] - 6.0e7*y[2]
7373
J[2,3] = -1.0e4*y[2]
7474
J[3,2] = 6.0e7*y[2]
75-
return Int32(0)
75+
return Sundials.CV_SUCCESS
7676
end
7777

7878
neq = 3

examples/cvode_Roberts_simplified.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function f(t, y, ydot)
66
ydot[1] = -0.04*y[1] + 1.0e4*y[2]*y[3]
77
ydot[3] = 3.0e7*y[2]*y[2]
88
ydot[2] = -ydot[1] - ydot[3]
9-
return(Int32(0))
9+
return Sundials.CV_SUCCESS
1010
end
1111
t = [0.0; 4 * logspace(-1., 7., 9)]
1212
res = Sundials.cvode(f, [1.0, 0.0, 0.0], t)

examples/ida_Cable.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ function cableres(t, u, up, r)
6565

6666
end
6767

68-
return (0)
68+
return Sundials.CV_SUCCESS
6969
end
7070

7171

@@ -99,21 +99,21 @@ function idabandsol(f::Function, y0::Vector{Float64}, yp0::Vector{Float64},
9999
flag = Sundials.IDAInit(mem, cfunction(Sundials.idasolfun, Int32,
100100
(Sundials.realtype, Sundials.N_Vector, Sundials.N_Vector, Sundials.N_Vector, Ref{Function})),
101101
t[1], nvector(y0), nvector(yp0))
102-
assert(flag == 0)
102+
assert(flag == Sundials.CV_SUCCESS)
103103
flag = Sundials.IDASetId(mem,nvector(id))
104-
assert(flag == 0)
104+
assert(flag == Sundials.CV_SUCCESS)
105105
flag = Sundials.IDASetUserData(mem, f)
106-
assert(flag == 0)
106+
assert(flag == Sundials.CV_SUCCESS)
107107
flag = Sundials.IDASStolerances(mem, reltol, abstol)
108-
assert(flag == 0)
108+
assert(flag == Sundials.CV_SUCCESS)
109109
mu = xsteps-1
110110
ml = xsteps-1
111111
flag = Sundials.IDABand(mem, neq, mu, ml)
112112
##flag = Sundials.IDADense(mem, neq)
113-
assert(flag == 0)
113+
assert(flag == Sundials.CV_SUCCESS)
114114
rtest = zeros(neq)
115115
flag = Sundials.IDACalcIC(mem, Sundials.IDA_YA_YDP_INIT, t[2])
116-
assert(flag == 0)
116+
assert(flag == Sundials.CV_SUCCESS)
117117
yres = zeros(length(t), length(y0))
118118
ypres = zeros(length(t), length(y0))
119119
yres[1,:] = y0

examples/ida_Heat2D.jl

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ function heatres(t, u, up, r)
5656
4.0 * u[loc])
5757
end
5858
end
59-
60-
return (0)
59+
60+
return Sundials.CV_SUCCESS
6161
end
6262

6363

@@ -117,22 +117,22 @@ function idabandsol(f::Function, y0::Vector{Float64}, yp0::Vector{Float64},
117117
flag = Sundials.IDAInit(mem, cfunction(Sundials.idasolfun, Int32,
118118
(Sundials.realtype, Sundials.N_Vector, Sundials.N_Vector, Sundials.N_Vector, Ref{Function})),
119119
t[1], nvector(y0), nvector(yp0))
120-
assert(flag == 0)
120+
assert(flag == Sundials.CV_SUCCESS)
121121
flag = Sundials.IDASetId(mem,nvector(id))
122-
assert(flag == 0)
122+
assert(flag == Sundials.CV_SUCCESS)
123123
flag = Sundials.IDASetConstraints(mem,nvector(constraints))
124-
assert(flag == 0)
124+
assert(flag == Sundials.CV_SUCCESS)
125125
flag = Sundials.IDASetUserData(mem, f)
126-
assert(flag == 0)
126+
assert(flag == Sundials.CV_SUCCESS)
127127
flag = Sundials.IDASStolerances(mem, reltol, abstol)
128-
assert(flag == 0)
128+
assert(flag == Sundials.CV_SUCCESS)
129129
mu = MGRID
130130
ml = MGRID
131131
flag = Sundials.IDABand(mem, neq, mu, ml)
132-
assert(flag == 0)
132+
assert(flag == Sundials.CV_SUCCESS)
133133
rtest = zeros(neq)
134134
flag = Sundials.IDACalcIC(mem, Sundials.IDA_YA_YDP_INIT, t[2])
135-
assert(flag == 0)
135+
assert(flag == Sundials.CV_SUCCESS)
136136
yres = zeros(length(t), length(y0))
137137
ypres = zeros(length(t), length(y0))
138138
yres[1,:] = y0

examples/ida_Roberts_dns.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function resrob(tres, yy, yp, rr, user_data)
4343
rval[2] = -rval[1] - 3.0e7*yval[2]*yval[2] - ypval[2]
4444
rval[1] -= ypval[1]
4545
rval[3] = yval[1] + yval[2] + yval[3] - 1.0
46-
return Cint(0) # indicates normal return
46+
return Sundials.IDA_SUCCESS
4747
end
4848

4949
## Root function routine. Compute functions g_i(t,y) for i = 0,1.
@@ -52,7 +52,7 @@ function grob(t, yy, yp, gout, user_data)
5252
gval = Sundials.asarray(gout, (2,))
5353
gval[1] = yval[1] - 0.0001
5454
gval[2] = yval[3] - 0.01
55-
return Cint(0) # indicates normal return
55+
return Sundials.IDA_SUCCESS
5656
end
5757

5858
## Define the Jacobian function. BROKEN - JJ is wrong
@@ -69,7 +69,7 @@ function jacrob(Neq, tt, cj, yy, yp, resvec,
6969
JJ[1,3] = 1.0e4*yval[2]
7070
JJ[2,3] = -1.0e4*yval[2]
7171
JJ[3,3] = 1.0
72-
return Cint(0) # indicates normal return
72+
return Sundials.IDA_SUCCESS
7373
end
7474

7575
neq = 3

examples/kinsol_mkinTest.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function sysfn(y_in, fy_in, a_in)
1818
fy = Sundials.asarray(fy_in)
1919
fy[1] = y[1]^2 + y[2]^2 - 1.0
2020
fy[2] = y[2] - y[1]^2
21-
return Cint(0) # indicates normal return
21+
return Sundials.KIN_SUCCESS
2222
end
2323

2424
## Initialize problem

0 commit comments

Comments
 (0)