Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #108 and update default ITP parameters to the ones in the paper.
Additional context
Additionally, the coefficient
κ₁
has been replaced in the ITP struct by a scale-invariant version that is dimensionally coherent. In the original ITP paper, they fix κ₁ so that the first scaled step is 20% of the interval, but for their test functions in the (-1,1) interval. This produces an algorithm that is not scale-invariant: just resizing the span (while appropriately "stretching" the corresponding function) can improve or degrade performance: see Fig. 1, which evaluates it on the test functions from the ITP paper:With the proposed changes in this PR (using a value that is equivalent to the "20% of the span" rule of thumb), this pattern disappears:
Code:
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.