-
-
Notifications
You must be signed in to change notification settings - Fork 222
Verbosity flag not correctly passed to linear solver #1897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is an OrdinaryDiffEq issue and not a LinearSolve.jl one. Pretty straightforward to fix though, just needs to be passed in the linear solve |
Then I will try to grab this. |
Since I am back here, let me try to get the discussion rolling. I think there is some information which we want to have when debugging convergence issues. For adaptive solvers we want to have some information about the error estimation and reason for rejection/retry of the step. For stiff solvers some information about the nonlinear solver is needed, e.g. current iteration and the convergence measure. Finally there might be issues in the linear solver, for which we to print out, which was the original concern of the issue. I did a prototype for this in the PR liked above, but the problem with just passing down the verbosity flag is that we do not have fine grained control about the outputs, such that we may get drained in noise if we just print out everything. I think we can approach this by introducing for the subpackages (LinearSolve.jl, NonlinearSolve.jl, OrdinaryDiffEq.jl,...) either xref JuliaHealth/Thunderbolt.jl#12 (comment) for some possible design |
We should make a set of defined structs in SciMLBase which are like, NonlinearProblemLogger, LinearProblemLogger, with a bunch of booleans or log-levels to turns things on and off. These could nest, so an ODEProblemLogger would have a NonlinearProblemLogger which would have a LinearProblemLogger to give full control all of the way down. |
I think we should continue here SciML/SciMLBase.jl#962 |
Reproducer
The text was updated successfully, but these errors were encountered: