Skip to content

Commit 1eef9db

Browse files
Merge pull request #2430 from ParamThakkar123/Fixes6
Perform step refactor for rosenbrock
2 parents 04a7c58 + bd9ec06 commit 1eef9db

File tree

8 files changed

+366
-882
lines changed

8 files changed

+366
-882
lines changed

lib/OrdinaryDiffEqDifferentiation/src/alg_utils.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,4 @@ end
7676
@generated function pick_static_chunksize(::Val{chunksize}) where {chunksize}
7777
x = ForwardDiff.pickchunksize(chunksize)
7878
:(Val{$x}())
79-
end
79+
end

lib/OrdinaryDiffEqDifferentiation/src/derivative_utils.jl

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ struct StaticWOperator{isinv, T, F} <: AbstractSciMLOperator{T}
1212
# doing to how StaticArrays and StaticArraysCore are split up
1313
StaticArrays.LU(LowerTriangular(W), UpperTriangular(W), SVector{n}(1:n))
1414
else
15-
lu(W, check = false)
15+
lu(W, check=false)
1616
end
1717
# when constructing W for the first time for the type
1818
# inv(W) can be singular
@@ -938,28 +938,28 @@ function LinearSolve.init_cacheval(
938938
end
939939

940940
for alg in [LinearSolve.AppleAccelerateLUFactorization,
941-
LinearSolve.BunchKaufmanFactorization,
942-
LinearSolve.CHOLMODFactorization,
943-
LinearSolve.CholeskyFactorization,
944-
LinearSolve.CudaOffloadFactorization,
945-
LinearSolve.DiagonalFactorization,
946-
LinearSolve.FastLUFactorization,
947-
LinearSolve.FastQRFactorization,
948-
LinearSolve.GenericFactorization,
949-
LinearSolve.GenericLUFactorization,
950-
LinearSolve.KLUFactorization,
951-
LinearSolve.LDLtFactorization,
952-
LinearSolve.LUFactorization,
953-
LinearSolve.MKLLUFactorization,
954-
LinearSolve.MetalLUFactorization,
955-
LinearSolve.NormalBunchKaufmanFactorization,
956-
LinearSolve.NormalCholeskyFactorization,
957-
LinearSolve.QRFactorization,
958-
LinearSolve.RFLUFactorization,
959-
LinearSolve.SVDFactorization,
960-
LinearSolve.SimpleLUFactorization,
961-
LinearSolve.SparspakFactorization,
962-
LinearSolve.UMFPACKFactorization]
941+
LinearSolve.BunchKaufmanFactorization,
942+
LinearSolve.CHOLMODFactorization,
943+
LinearSolve.CholeskyFactorization,
944+
LinearSolve.CudaOffloadFactorization,
945+
LinearSolve.DiagonalFactorization,
946+
LinearSolve.FastLUFactorization,
947+
LinearSolve.FastQRFactorization,
948+
LinearSolve.GenericFactorization,
949+
LinearSolve.GenericLUFactorization,
950+
LinearSolve.KLUFactorization,
951+
LinearSolve.LDLtFactorization,
952+
LinearSolve.LUFactorization,
953+
LinearSolve.MKLLUFactorization,
954+
LinearSolve.MetalLUFactorization,
955+
LinearSolve.NormalBunchKaufmanFactorization,
956+
LinearSolve.NormalCholeskyFactorization,
957+
LinearSolve.QRFactorization,
958+
LinearSolve.RFLUFactorization,
959+
LinearSolve.SVDFactorization,
960+
LinearSolve.SimpleLUFactorization,
961+
LinearSolve.SparspakFactorization,
962+
LinearSolve.UMFPACKFactorization]
963963
@eval function LinearSolve.init_cacheval(alg::$alg, A::WOperator, b, u, Pl, Pr,
964964
maxiters::Int, abstol, reltol, verbose::Bool,
965965
assumptions::OperatorAssumptions)
@@ -1003,4 +1003,4 @@ function resize_J_W!(cache, integrator, i)
10031003
end
10041004

10051005
nothing
1006-
end
1006+
end

lib/OrdinaryDiffEqRosenbrock/src/interp_func.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function DiffEqBase.interp_summary(::Type{cacheType},
1212
dense::Bool) where {
1313
cacheType <:
1414
Union{Rodas4ConstantCache, Rodas23WConstantCache, Rodas3PConstantCache,
15-
Rodas4Cache, Rodas23WCache, Rodas3PCache}}
15+
RosenbrockCache, Rodas23WCache, Rodas3PCache}}
1616
dense ? "specialized 3rd order \"free\" stiffness-aware interpolation" :
1717
"1st order linear"
1818
end

0 commit comments

Comments
 (0)