Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing MTKParameters handling in linearize #3006

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

AayushSabharwal
Copy link
Member

Close #2941

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Sep 2, 2024

I have tested that the reduced MWE in tests fails when any of the changes in the PR are reverted, and that the original MWE now runs (with allow_input_derivatives = true)

@AayushSabharwal
Copy link
Member Author

Waiting on #3020 to be able to run CI properly

@ChrisRackauckas ChrisRackauckas merged commit 9000837 into SciML:master Sep 7, 2024
21 of 23 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-linearization branch September 7, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MTK & linearization -- MTKParameters access out of bounds
2 participants