Merge pull request #172 from SciML/klu

Fix and test KLU slow branch

Author: ChrisRackauckas

src/factorization.jl

@@ -299,7 +299,9 @@ function SciMLBase.solve(cache::LinearCache, alg::KLUFactorization; kwargs...)
             end
             fact = KLU.klu!(cache.cacheval, A)
         else
-            fact = do_factorization(alg, A, cache.b, cache.u)
+            # New fact each time since the sparsity pattern can change
+            # and thus it needs to reallocate
+            fact = KLU.klu(A)
         end
         cache = set_cacheval(cache, fact)
     end

test/basictests.jl

@@ -108,6 +108,7 @@ end
         prob1 = LinearProblem(sparse(A1), b1; u0 = x1)
         prob2 = LinearProblem(sparse(A2), b2; u0 = x2)
         test_interface(KLUFactorization(), prob1, prob2)
+        test_interface(KLUFactorization(reuse_symbolic = false), prob1, prob2)
 
         # Test that refactoring wrong throws.
         cache = SciMLBase.init(prob1, KLUFactorization(); cache_kwargs...) # initialize cache