Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Enzyme 0.13 #85

Open
wsmoses opened this issue Sep 16, 2024 · 5 comments
Open

Adapt to Enzyme 0.13 #85

wsmoses opened this issue Sep 16, 2024 · 5 comments

Comments

@wsmoses
Copy link
Collaborator

wsmoses commented Sep 16, 2024

Enzyme has a pending breaking release upcoming.

One notable addition is runtime activity being part of the mode now, we well as (potentially) moving whether the primal is returned as part of the mode.

Runtime activity probably makes sense to add to ADTypes, whether to return the primal, also potentially (though the latter hasn't even landed yet)

@gdalle
Copy link
Collaborator

gdalle commented Sep 16, 2024

Well, if everything becomes part of the mode, I guess we're fine cause ADTypes already include the mode field in AutoEnzyme?

@gdalle
Copy link
Collaborator

gdalle commented Sep 19, 2024

@wsmoses do you think we have anything to change here?

@gdalle
Copy link
Collaborator

gdalle commented Sep 19, 2024

@wsmoses
Copy link
Collaborator Author

wsmoses commented Sep 25, 2024

@gdalle can this be reopened. I still think it's worth adding runtime activity here or something

@gdalle gdalle reopened this Sep 25, 2024
@gdalle
Copy link
Collaborator

gdalle commented Sep 25, 2024

Why, if it is already in the mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants