Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests fort datasets empty accessGroups #1224

Open
nitrosx opened this issue May 27, 2024 · 0 comments
Open

Add tests fort datasets empty accessGroups #1224

nitrosx opened this issue May 27, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed testing Anything relating with tests and testing

Comments

@nitrosx
Copy link
Contributor

nitrosx commented May 27, 2024

Summary

Currently we do not test authorization when the dataset accessGroups is an empty list.

Current Behavior

The behavior experienced prior PR #1203 was that Datasets with accessGroups set to an empty list would grant access to every user who had empty list in currentGroups.

Expected Behaviour

The expected behavior should be that the empty strings are removed from any group list both on datasets and users.
@nitrosx nitrosx added enhancement New feature or request help wanted Extra attention is needed testing Anything relating with tests and testing labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed testing Anything relating with tests and testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nitrosx