Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Being able to change light/dark theme in project menu #241

Open
3 tasks done
louisgreiner opened this issue Aug 14, 2024 · 3 comments
Open
3 tasks done
Labels

Comments

@louisgreiner
Copy link
Collaborator

Preflight Checklist

Request type

Request for enhancement of a component

Functionality

image

It would be nice to be able to change the theme (light/dark) directly in project menu, not to have to wait to be in a variant

Link to design proposal file

No response

@aiAdrian
Copy link
Collaborator

Sounds interesting. I understand the problem. One problem I also encountered is that the user can only change the color themes in the variant. The color theme (setting) could also be added to the language settings as it is a global setting which is neither project nor variant specific. So for me the question is: remove it from the variant settings and move the whole feature near the user settings or leave it in both places. What is best for UX?

@aiAdrian aiAdrian added enhancement New feature or request good first issue Good for newcomers UX (enhancement) and removed enhancement New feature or request labels Aug 19, 2024
@louisgreiner
Copy link
Collaborator Author

I fully agree with moving out the color theme feature outside variant settings.

In my opinion, it would be better if it fit at 1 place only

@aiAdrian
Copy link
Collaborator

aiAdrian commented Aug 27, 2024

I totally agree that we need to consider whether and how we provide all settings (global - i.e., valid across all projects/variants and user-dependent (Browser: local storage)) to the user. The color scheme is basically needed only in the editor, like all other settings, i.e., project and variant pages are 'colorless.' Here, only the Dark/Light mode is reacted to. Therefore, I wonder whether it should be handled like the language setting or if we should leave the settings as they are currently. Then we would just need to find a logic for how we can switch between Dark/Light modes.
I would appreciate it if we could build it analogously to the language setting.

  • These adjustments are not yet perfectly designed. Perhaps we could discuss this with a UX expert, or they could make a suggestion.

-To summarize: We have global settings like language, which must take effect from the first page, colors, Editor: travel time, graphical timetable (Streckengrafik): temporal scaling which only take effect in the editor or in the graphical timetable. These settings should be made as accessible as possible to the user so that they can find these functions quickly and easily

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants