SBBPagination: Simplification and Animation #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallTrogdor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #227.
The
SBBPaginationwas simplified: Previously, the circles were drawn using a CustomPainter and a Oval on a Canvas. This not only lead to incorrect sizes (that are hard to track in the tooling), but also to non easy animation.The setup was simplified by using
AnimatedContainer(s) that take the shape of a Circle. There is a margin added, if the Circle is not the selected one (to account for the size difference between the selected and unselected circles).The result is simpler code and a nice easy animation 🤩 WIN - WIN 🎆
Here a short demo of the animation:
Screen.Recording.2025-01-08.at.14.57.44.mov