Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development dependency specification #63

Open
Descent098 opened this issue Nov 7, 2020 · 0 comments
Open

Development dependency specification #63

Descent098 opened this issue Nov 7, 2020 · 0 comments

Comments

@Descent098
Copy link
Member

With python you can specify "extra" requirements that can be conditionally installed. In our case we can add "dev" dependencies that are installed using pip install schulich-ignite[dev].

This would make the onboarding process easier for people. To do this we need to add the following lines to the bottom of setup.py:

setuptools.setup(
    ... # Other metadata
    install_requires=[
        'ipywidgets',
        'ipycanvas',
        'ipyevents'
    ],
    extras_require = {
        "dev" : [
                "mkdocs", 
                "mkdocs-material"]
)

While we're at it I think we should also add jupyter lab as a dependency. So it would be:

setuptools.setup(
    ... # Other metadata
    install_requires=[
        'jupyterlab'
        'ipywidgets',
        'ipycanvas',
        'ipyevents'
    ],
    extras_require = {
        "dev" : [
                "mkdocs", 
                "mkdocs-material"]
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant