Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Create projects page #44

Closed
wants to merge 13 commits into from
Closed

[WIP]: Create projects page #44

wants to merge 13 commits into from

Conversation

AngyDev
Copy link
Member

@AngyDev AngyDev commented Jan 26, 2023

Summary

Changes

What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for suspicious-boyd-b429fe ready!

Name Link
🔨 Latest commit 594119f
🔍 Latest deploy log https://app.netlify.com/sites/suspicious-boyd-b429fe/deploys/64881a7cea434e0009f30204
😎 Deploy Preview https://deploy-preview-44--suspicious-boyd-b429fe.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Readpato
Copy link
Member

I was reviewing the new dependencies that have been installed for this feature and the JW Vue Pagination does not support Vue 3.
I'm afraid that when the migration from Vue2 to Vue3 is ready we won't be able to integrate it correctly causing a broken feature in the project and we would need to build it again from scratch.
Maybe we can find a library that supports either Vue2 and Vue3?

@AngyDev
Copy link
Member Author

AngyDev commented Jan 26, 2023

Yes @Readpato you are right, I found https://www.npmjs.com/package/v-pagination-3, it's for vue3. I hadn't thought to look for a compatible one for both versions.
I used the library compatible with vue2 to try the usage, when the migration will be ready we can change the library.

@Wabri Wabri added the enhancement New feature or request label Jan 26, 2023
@Readpato
Copy link
Member

Looking into that repository it seems that it needs either Bootstrap 3 or 4 as a dependency, which we currently do not use and I don't know if adding another dependency for a single feature is a good move, maybe it's up for discussion?

Doing a little bit of research I found this one here Vue awesome paginate which it seems more recently updated and it also utilizes Typescript and Vue instead of mostly vanilla JavaScript as the previous one. What do you think @AngyDev wanna give it a check?

@AngyDev
Copy link
Member Author

AngyDev commented Jan 28, 2023

I agree with you @Readpato, I wouldn't add new dependencies. In addition, the repository seems archived, I don't know why I didn't see it. However, I saw the Vue awesome paginated but if I remember correctly we haven't Typescript yet. I think it's possible to use it also with javascript, what do you think?

@Readpato
Copy link
Member

Seems super good to me! I'm adding Typescript with the migration so it would be a natural step to take forward. If it doesn't work without adding Typescript as a dependency I would do it anyways and proceed with it 💪

@Readpato
Copy link
Member

Readpato commented May 6, 2023

Adding the list of things that were discussed last time on the meeting that need to be updated for this PR to be merged:

  • Add a short description for all the projects
  • Do not implement a specific page for the project
  • Create different chips for status on project:
    • Searching for contributors
    • Has good first issues
    • Etc.
  • Make it easier for people find and understand the projects
  • Show only SH projects (for now)
  • Separate projects by:
    • Topic (Language, Backend, Frontend)
    • Difficulty (has issues that can be solved easily)
  • Make it clear who is the referent of the project so it can be contacted easily.
  • Review card UI and responsiveness on mobile

@TheJoin95
Copy link
Member

Could you please rebase?

@Wabri
Copy link
Member

Wabri commented Jun 13, 2023

Maybe dark theme is broken
image

@Readpato Readpato changed the title WIP: Projects page [WIP]: Refactor projects page Oct 30, 2023
@Readpato Readpato changed the title [WIP]: Refactor projects page [WIP]: Create projects page Oct 30, 2023
@TheJoin95
Copy link
Member

Not sure, but I think we can close this

@TheJoin95 TheJoin95 closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants