-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Create projects page #44
Conversation
✅ Deploy Preview for suspicious-boyd-b429fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I was reviewing the new dependencies that have been installed for this feature and the JW Vue Pagination does not support Vue 3. |
Yes @Readpato you are right, I found https://www.npmjs.com/package/v-pagination-3, it's for vue3. I hadn't thought to look for a compatible one for both versions. |
Looking into that repository it seems that it needs either Bootstrap 3 or 4 as a dependency, which we currently do not use and I don't know if adding another dependency for a single feature is a good move, maybe it's up for discussion? Doing a little bit of research I found this one here Vue awesome paginate which it seems more recently updated and it also utilizes Typescript and Vue instead of mostly vanilla JavaScript as the previous one. What do you think @AngyDev wanna give it a check? |
I agree with you @Readpato, I wouldn't add new dependencies. In addition, the repository seems archived, I don't know why I didn't see it. However, I saw the Vue awesome paginated but if I remember correctly we haven't Typescript yet. I think it's possible to use it also with javascript, what do you think? |
Seems super good to me! I'm adding Typescript with the migration so it would be a natural step to take forward. If it doesn't work without adding Typescript as a dependency I would do it anyways and proceed with it 💪 |
Adding the list of things that were discussed last time on the meeting that need to be updated for this PR to be merged:
|
3b46019
to
14b2e69
Compare
Could you please rebase? |
14b2e69
to
fd12d9b
Compare
a5f30b5
to
594119f
Compare
Not sure, but I think we can close this |
Summary
Changes
What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements: