Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli - add option to process folder #3

Open
Wabri opened this issue Feb 20, 2022 · 10 comments
Open

Cli - add option to process folder #3

Wabri opened this issue Feb 20, 2022 · 10 comments
Assignees

Comments

@Wabri
Copy link
Member

Wabri commented Feb 20, 2022

Add option -d or --dir

Reference to the main request: https://www.reddit.com/r/ImageGoNord/comments/sx8fl3/question_is_there_a_way_to_process_a_folder/

@Wabri Wabri self-assigned this Feb 22, 2022
@Wabri Wabri removed their assignment Mar 3, 2022
@Artmorse
Copy link
Contributor

Hi,

Can you assign me this issue ? 😃

@TheJoin95
Copy link
Member

Sure!

@Wabri
Copy link
Member Author

Wabri commented Aug 26, 2022

@Artmorse We are moving the cli to another repository (#110) to make the scope clear to every users.

When Schroedinger-Hat/ImageGoNord-Web#110 will be close I will move your pr to the new repository 😊

@Wabri Wabri transferred this issue from Schroedinger-Hat/ImageGoNord-Web Sep 1, 2022
@TheJoin95
Copy link
Member

Is this done or still in process? @Wabri

@Wabri
Copy link
Member Author

Wabri commented Apr 16, 2024

No PR referred to so still in process

@Wabri
Copy link
Member Author

Wabri commented Apr 16, 2024

@Artmorse are you willing to continue this?a

@Artmorse
Copy link
Contributor

Artmorse commented Apr 16, 2024

hey @TheJoin95, if you want to work on it, go ahead, if not, I can try to have a look at it during next week 🙂

@TheJoin95
Copy link
Member

@Artmorse I let you take this :)
I'm focusing in some other areas of the IGN project, thanks!

@Artmorse
Copy link
Contributor

Artmorse commented May 29, 2024

Looking a bit more deeply at the project it seems they're unwanted behaviors (I'll create some issues).

For this ticket, the easiest thing to do now to use folders is to create a little BASH script (see below ⬇️).

INPUT_FOLDER="./image-test" ; for file in $(ls $INPUT_FOLDER/*.jpg) ; do python src/cli.py --img="$INPUT_FOLDER/$file" ; done

# we can also improve the behavior by adding output folder
INPUT_FOLDER="./input-folder" ; OUTPUT_FOLDER="./output-folder" ; mkdir -p $OUTPUT_FOLDER ; for file in $(ls $INPUT_FOLDER/*.jpg); do filename=$(basename $file) ; python src/cli.py --img="$INPUT_FOLDER/$filename" -o="$OUTPUT_FOLDER/$filename" ; done

I'm working on the implementation of the feature though.

@Wabri
Copy link
Member Author

Wabri commented May 29, 2024

Thanks @Artmorse 💯

Wabri added a commit that referenced this issue Oct 14, 2024
Update client with argparse (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants