Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-www switch #19

Open
szepeviktor opened this issue Jul 11, 2022 · 5 comments
Open

Add non-www switch #19

szepeviktor opened this issue Jul 11, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@szepeviktor
Copy link

szepeviktor commented Jul 11, 2022

While checking a www website manually I've noticed there are non-www (broken?) links.

  website_url: 'https://www.website.test'
  include_url_prefix: 'https://www.website.test'
  resolve_before_filtering: 'true'

Please consider adding a www switch that includes/follows non-www links.

@szepeviktor
Copy link
Author

szepeviktor commented Jul 11, 2022

And maybe the reverse too

  website_url: 'https://website.test'
  include_url_prefix: 'https://website.test'
  resolve_before_filtering: 'true'

that includes/follows www links.

@ScholliYT
Copy link
Owner

Are you talking about following links like https://www.website.test given the following config:

  website_url: 'https://website.test'
  include_url_prefix: 'https://website.test'
  resolve_before_filtering: 'true'
  auto_follow_www: 'true'

Can you maybe add a real website where the Issue exists? That would be very helpful.

@szepeviktor
Copy link
Author

szepeviktor commented Jul 11, 2022

Thank you for your response!

Here it is
https://github.com/szepeviktor/bankitamas.hu_404/runs/7287428037?check_suite_focus=true

This website has many non-www links, e.g. on this page https://www.bankitamas.hu/bekapcsol.html

@szepeviktor
Copy link
Author

This seems to change things.
include_url_prefix: "https://www.bankitamas.hu,https://bankitamas.hu"
But I'd like to keep this issue open.

@ScholliYT
Copy link
Owner

ScholliYT commented Jul 11, 2022

Yes, the current solution is to include both the www and non-www version in include_url_prefix.

Maybe a solution allowing you to specify prefixes / subdomains (e.g., www to auto follow for all domains would be a general solution to this.

@ScholliYT ScholliYT added the enhancement New feature or request label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants