-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support cargo-binstall #1280
Comments
On Ubuntu, It will use the quickInstall source, and on Windows, fnm will compile from source. |
@ahaoboy This sounds like a fun issue to work on! I'd love to pick it up. My Approach is simple :
Let me know if this approach works, and I'd be happy to get started! |
This sounds good and I’d love to see that contributed! I suggest stacking these changes on a fork so we see that it works (all the release process has a very slow feedback loop). I think it will be best to first have both fnm-macos.zip etc along to the new files, so we can make sure all installers are updated (like winget, brew, apt etc). We just symlink or duplicate release artifacts to avoid breaking :) if there are any issues I can try to help |
Making cross compile work faster and nicer is pretty cool. Maybe with |
It is not clear whether fnm-macos is currently x86_64 or arm64, perhaps it should support both
|
I often use this action, it is easier to use than cargo-dist |
@Schniz @ahaoboy Could you confirm which binaries are currently being generated for each platform (e.g., This is in referrence to any existing work/ open PR's on the same |
cargo-binstall has full list, but we don't need support all of them |
Because actions/upload-artifact@v4 is used to compress files, CRC calculation errors occur. cargo-bins/cargo-binstall#1080. Therefore, zip packages such as fnm-windows.zip cannot be used even if metadata is added. It needs to be tested to prevent this problem. You can test whether the local Cargo.toml is configured correctly by the following command
Also, should the meta information be added to Cargo.toml? Using binstall.toml will duplicate package information, and I'm not sure if it will work.
|
https://github.com/cargo-bins/cargo-binstall
cargo-binstall can skip the compilation process. fnm has released executable programs for different platforms, but it does not support cargo-binstall.
The text was updated successfully, but these errors were encountered: