Skip to content

Commit d016790

Browse files
authored
Merge pull request #152 from Say-Their-Name/development
Fix news
2 parents f37c77e + 88968d8 commit d016790

File tree

5 files changed

+49
-17
lines changed

5 files changed

+49
-17
lines changed

.env.example

+6-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,9 @@
22
EXTEND_ESLINT=true
33
REACT_APP_API_BASE_URL=https://saytheirnames.dev/api
44
REACT_APP_GA_TRACKING_ID=GA_TRACKING_ID
5-
5+
REACT_APP_NEWS_FETCH_PROXY=REACT_APP_NEWS_FETCH_PROXY
6+
REACT_APP_TWITTER_URL=REACT_APP_TWITTER_URL
7+
REACT_APP_FACEBOOK_URL=REACT_APP_FACEBOOK_URL
8+
REACT_APP_INSTAGRAM_URL=REACT_APP_INSTAGRAM_URL
9+
REACT_APP_ANDROID_URL=REACT_APP_ANDROID_URL
10+
REACT_APP_IOS_URL=REACT_APP_IOS_URL

.github/workflows/unit-test.yaml

+14-10
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,21 @@ name: Unit Test Workflow
22

33
on:
44
pull_request:
5-
branches: [ master, development ]
5+
branches: [master, development]
66

77
jobs:
88
unit_test_pull_request:
99
runs-on: ubuntu-latest
10-
steps:
11-
- uses: actions/checkout@v2
12-
- uses: actions/setup-node@v1
13-
with:
14-
node-version: 12
15-
- name: Install Node Dependencies
16-
run: yarn install --frozen-lockfile
17-
- name: Run all Unit Tests
18-
run: CI=true yarn test
10+
steps:
11+
- uses: actions/checkout@v2
12+
- uses: actions/setup-node@v1
13+
with:
14+
node-version: 12
15+
- name: Install Node Dependencies
16+
run: yarn install --frozen-lockfile
17+
- name: Run all Unit Tests
18+
run: CI=true yarn test
19+
env:
20+
REACT_APP_TWITTER_URL: https://twitter.com/SayTheirName_io
21+
REACT_APP_FACEBOOK_URL: https://www.facebook.com/Say-Their-Names-108926117523025/?modal=admin_todo_tour
22+
REACT_APP_INSTAGRAM_URL: https://www.instagram.com/saytheirname.iocat

README.md

+15-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
![Unit Test Workflow](https://github.com/Say-Their-Name/say-their-names-web/workflows/Unit%20Test%20Workflow/badge.svg)
2+
13
# Say Their Names ✊🏿
24

35
## Overview
@@ -28,12 +30,24 @@ Using SSH:
2830
```
2931

3032
### Navigate to app
33+
3134
```sh
3235
cd say-their-names-web
3336
```
3437

3538
### Add Environment Variable
36-
Create a `.env` file in the root of the project and copy the contents of `.env.example` file to the newly created `.env` file.
39+
40+
Create a `.env` file in the root of the project and copy the contents below to the newly created `.env` file.
41+
42+
```
43+
REACT_APP_API_BASE_URL=https://saytheirnames.dev/api
44+
REACT_APP_NEWS_FETCH_PROXY=https://thingproxy.freeboard.io/fetch
45+
REACT_APP_TWITTER_URL=https://twitter.com/SayTheirName_io
46+
REACT_APP_FACEBOOK_URL=https://www.facebook.com/Say-Their-Names-108926117523025/?modal=admin_todo_tour
47+
REACT_APP_INSTAGRAM_URL=https://www.instagram.com/saytheirname.io
48+
REACT_APP_ANDROID_URL=https://play.google.com/store/apps/details?id=io.saytheirnames.android
49+
REACT_APP_IOS_URL=https://apps.apple.com/app/say-their-names/id1517599626
50+
```
3751

3852
### Installing Dependencies
3953

src/components/ui/news/News.js

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const News = ({ news }) => {
1717
minLine={1}
1818
url={news.url}
1919
loadSecureUrl
20+
proxyUrl={process.env.REACT_APP_NEWS_FETCH_PROXY}
2021
onSuccess={() => setDisplay('block')}
2122
onError={() => setDisplay('none')}
2223
/>

src/constants/Variables.js

+13-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,15 @@
1+
const {
2+
REACT_APP_TWITTER_URL,
3+
REACT_APP_FACEBOOK_URL,
4+
REACT_APP_INSTAGRAM_URL,
5+
REACT_APP_ANDROID_URL,
6+
REACT_APP_IOS_URL
7+
} = process.env;
8+
19
export default {
2-
TWITTER_URL: 'https://twitter.com/SayTheirName_io',
3-
FACEBOOK_URL: 'https://www.facebook.com/Say-Their-Names-108926117523025/?modal=admin_todo_tour',
4-
INSTAGRAM_URL: 'https://www.instagram.com/saytheirname.io/',
5-
ANDROID_URL: '#',
6-
IOS_URL: 'https://apps.apple.com/app/say-their-names/id1517599626'
10+
TWITTER_URL: REACT_APP_TWITTER_URL,
11+
FACEBOOK_URL: REACT_APP_FACEBOOK_URL,
12+
INSTAGRAM_URL: REACT_APP_INSTAGRAM_URL,
13+
ANDROID_URL: REACT_APP_ANDROID_URL,
14+
IOS_URL: REACT_APP_IOS_URL
715
};

0 commit comments

Comments
 (0)