Skip to content

Commit 750bbab

Browse files
authored
Merge pull request #164 from Say-Their-Name/feature/contribution-links-footer
Added contribution footer for github and slack links.
2 parents 88968d8 + 1ab60b3 commit 750bbab

File tree

8 files changed

+39
-2
lines changed

8 files changed

+39
-2
lines changed

.env.example

+2
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,7 @@ REACT_APP_NEWS_FETCH_PROXY=REACT_APP_NEWS_FETCH_PROXY
66
REACT_APP_TWITTER_URL=REACT_APP_TWITTER_URL
77
REACT_APP_FACEBOOK_URL=REACT_APP_FACEBOOK_URL
88
REACT_APP_INSTAGRAM_URL=REACT_APP_INSTAGRAM_URL
9+
REACT_APP_GITHUB_URL=REACT_APP_GITHUB_URL
10+
REACT_APP_SLACK_URL=REACT_APP_SLACK_URL
911
REACT_APP_ANDROID_URL=REACT_APP_ANDROID_URL
1012
REACT_APP_IOS_URL=REACT_APP_IOS_URL

README.md

+2
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ REACT_APP_NEWS_FETCH_PROXY=https://thingproxy.freeboard.io/fetch
4545
REACT_APP_TWITTER_URL=https://twitter.com/SayTheirName_io
4646
REACT_APP_FACEBOOK_URL=https://www.facebook.com/Say-Their-Names-108926117523025/?modal=admin_todo_tour
4747
REACT_APP_INSTAGRAM_URL=https://www.instagram.com/saytheirname.io
48+
REACT_APP_GITHUB_URL=https://github.com/Say-Their-Name
49+
REACT_APP_SLACK_URL=https://app.slack.com/client/T014JL5B3SN/C014X92G997
4850
REACT_APP_ANDROID_URL=https://play.google.com/store/apps/details?id=io.saytheirnames.android
4951
REACT_APP_IOS_URL=https://apps.apple.com/app/say-their-names/id1517599626
5052
```

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
"start": "react-scripts start",
2828
"build": "react-scripts build",
2929
"test": "react-scripts test",
30-
"test:all": "yarn run lint:fix && CI=true yarn test",
31-
"test:coverage": "CI=true yarn test --coverage --watchAll=false",
30+
"test:all": "yarn run lint:fix && yarn test --CI=true",
31+
"test:coverage": "yarn test --coverage --watchAll=false --CI=true",
3232
"eject": "react-scripts eject",
3333
"lint": "eslint src",
3434
"lint:fix": "eslint src --fix"

src/assets/github.svg

+4
Loading

src/assets/slack.svg

+4
Loading

src/components/footer/Footer.js

+20
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import Apple from '../../assets/AppStorebadge.svg';
77
import Twitter from '../../assets/twitter.svg';
88
import Facebook from '../../assets/facebook.svg';
99
import Instagram from '../../assets/instagram.svg';
10+
import Github from '../../assets/github.svg';
11+
import Slack from '../../assets/slack.svg';
1012
import Variables from '../../constants/Variables';
1113

1214
import {
@@ -89,6 +91,24 @@ const Footer = () => (
8991
>
9092
<img src={Instagram} alt="instagram-handle" />
9193
</a>
94+
<br />
95+
<h2>CONTRIBUTE</h2>
96+
<a
97+
style={{ marginTop: '1rem', textDecoration: 'none' }}
98+
target="_blank"
99+
rel="noopener noreferrer"
100+
href={Variables.GITHUB_URL}
101+
>
102+
<img src={Github} alt="github-handle" />
103+
</a>
104+
<a
105+
style={{ marginTop: '1rem', textDecoration: 'none' }}
106+
target="_blank"
107+
rel="noopener noreferrer"
108+
href={Variables.SLACK_URL}
109+
>
110+
<img src={Slack} alt="slack-handle" />
111+
</a>
92112
</StyledFooter>
93113
</FooterContainer>
94114
</Container>

src/components/footer/Footer.test.js

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ describe('<Footer />', () => {
2323
expect(getByText('Our Mission'));
2424
// expect(getByText('DOWNLOADS (Coming shortly)'));
2525
expect(getByText('JOIN US ON SOCIAL MEDIA'));
26+
expect(getByText('CONTRIBUTE'));
2627
});
2728

2829
test('renders correct links', () => {

src/constants/Variables.js

+4
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ const {
22
REACT_APP_TWITTER_URL,
33
REACT_APP_FACEBOOK_URL,
44
REACT_APP_INSTAGRAM_URL,
5+
REACT_APP_GITHUB_URL,
6+
REACT_APP_SLACK_URL,
57
REACT_APP_ANDROID_URL,
68
REACT_APP_IOS_URL
79
} = process.env;
@@ -10,6 +12,8 @@ export default {
1012
TWITTER_URL: REACT_APP_TWITTER_URL,
1113
FACEBOOK_URL: REACT_APP_FACEBOOK_URL,
1214
INSTAGRAM_URL: REACT_APP_INSTAGRAM_URL,
15+
GITHUB_URL: REACT_APP_GITHUB_URL,
16+
SLACK_URL: REACT_APP_SLACK_URL,
1317
ANDROID_URL: REACT_APP_ANDROID_URL,
1418
IOS_URL: REACT_APP_IOS_URL
1519
};

0 commit comments

Comments
 (0)