-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export common AssetIds #13
Comments
Is it possible to include: Depix -> 02f22f8d9c76ab41661a2729e4752e2c5d1a263012141b86ea98af5472df5189 |
I want to understand what will be the type of behaviour you will want to add to lwk dart. Are you thinking in adding somekind of token parsing on lwk so that user just says balances.usdt Or Are you just planning in creating a getter where it will return to the user the string of the asset if and then we parse it to whatever asset it corresponds on our end? |
Upon further investigation i see that for now on my end i can just get the first parameter of the List and parse the id on my end. Will you deprecate this ability? Ideally we would keep the the List<(string, int)> but then just add some getters for the common assets 🤔 |
The benefit of having List<(String, int)> is that is allows the end user to manage whatever assets they like. Adding getters for common assets is a good idea. This could be a simple PR for you to give a try. |
As soon as I have the basic behaviour in my app done I will start tackling these. 😀 |
Currently AssetIds are in root.dart as consts. Will be better to move them to a constants.dart file. |
The library should export commonly used AssetIds:
The text was updated successfully, but these errors were encountered: