Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export common AssetIds #13

Open
i5hi opened this issue Mar 27, 2024 · 6 comments
Open

Export common AssetIds #13

i5hi opened this issue Mar 27, 2024 · 6 comments
Assignees

Comments

@i5hi
Copy link
Collaborator

i5hi commented Mar 27, 2024

The library should export commonly used AssetIds:

  • L-BTC
  • L-TEST
  • L-USDT
  • L-CAD
@i5hi i5hi self-assigned this Mar 27, 2024
@Saleciani
Copy link
Contributor

Is it possible to include:

Depix -> 02f22f8d9c76ab41661a2729e4752e2c5d1a263012141b86ea98af5472df5189
Pegx Eur -> 18729918ab4bca843656f08d4dd877bed6641fbd596a0a963abbf199cfeb3cec

@Saleciani
Copy link
Contributor

I want to understand what will be the type of behaviour you will want to add to lwk dart.
Right now balances is a List<(string, int)>

Are you thinking in adding somekind of token parsing on lwk so that user just says balances.usdt

Or

Are you just planning in creating a getter where it will return to the user the string of the asset if and then we parse it to whatever asset it corresponds on our end?

@Saleciani
Copy link
Contributor

Upon further investigation i see that for now on my end i can just get the first parameter of the List and parse the id on my end.

Will you deprecate this ability?

Ideally we would keep the the List<(string, int)> but then just add some getters for the common assets 🤔

@i5hi
Copy link
Collaborator Author

i5hi commented Apr 12, 2024

The benefit of having List<(String, int)> is that is allows the end user to manage whatever assets they like.

Adding getters for common assets is a good idea.

This could be a simple PR for you to give a try.

@Saleciani
Copy link
Contributor

As soon as I have the basic behaviour in my app done I will start tackling these. 😀

@i5hi
Copy link
Collaborator Author

i5hi commented Apr 13, 2024

Currently AssetIds are in root.dart as consts.

Will be better to move them to a constants.dart file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants