Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bump fee] Related issues/queries #201

Open
3 of 6 tasks
saiy2k opened this issue Nov 16, 2023 · 10 comments
Open
3 of 6 tasks

[Bump fee] Related issues/queries #201

saiy2k opened this issue Nov 16, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@saiy2k
Copy link
Contributor

saiy2k commented Nov 16, 2023

App version: 0.1.97 (001325b)

  • (Sometimes) The bump fee button is not getting displayed. (Will try to figure out the exact condition)
  • Immediately after bumping, in the home txn list, I am able to see both the previous txn and current bumped txn for a while. Is this normal?
  • After some 8-10 bumps, the 'bump' button is not visible. I checked the txn is still unconfirmed. Is this expected?

Happening with 51c9528

  • Redirection popup gets stuck in the same state (Screen recording @ [Bump fee] Related issues/queries #201 (comment)) Remove the close button. Let it redirect to home page after 2 seconds.
  • Panic exception happens when trying to bump once txn is confirmed. Could have better error message that "Txn is now confirmed. Cannot bump".

Happening with (4f0ef5b) v0.1.98-04

BumpFee.mp4
@i5hi
Copy link
Collaborator

i5hi commented Nov 20, 2023

bump currently wont show up for imported wallets.

@mocodesmo we need to use the method from bdkTx.isExplicitlyRBF() for imported wallets to get rbfEnabled: bool value

@i5hi
Copy link
Collaborator

i5hi commented Nov 20, 2023

I think its normal to momentarily see both. This is bdk's behaviour.

@i5hi i5hi added the bug Something isn't working label Nov 20, 2023
@mocodesmo
Copy link
Collaborator

@i5hi can we close this ?

@i5hi
Copy link
Collaborator

i5hi commented Nov 21, 2023

@mocodesmo we need to address the first point with isExplicitlyRbf - as of now imported wallets do not show bump fee for a tx with rbfEnabled.

@saiy2k not sure about the last point, we will need to test that a bit further.

@saiy2k
Copy link
Contributor Author

saiy2k commented Nov 22, 2023

@i5hi 15+ continuous bumps are working good.

@saiy2k
Copy link
Contributor Author

saiy2k commented Nov 22, 2023

After bump, I close the redirection popup within 2 seconds (before redirection) and then it's stuck in the same state.

bump.fee.005.mp4

@saiy2k
Copy link
Contributor Author

saiy2k commented Nov 22, 2023

On #1, Bump fee button not appearing for few times, on opening the tnx page. But then appearning on multiple tries.

bump.fee.006.mp4

@saiy2k
Copy link
Contributor Author

saiy2k commented Nov 22, 2023

Also, bump is not visible in cases, where txn is signed in some other wallet and broadcasted with BB. Then later the same wallet is imported

Bump.fee.007.mp4

@saiy2k
Copy link
Contributor Author

saiy2k commented Nov 27, 2023

Something wrong with fee calculation, while doing bump.

For a 2 sats/byte txn, I am trying to bump it to 4.
And it says "Requrired fee is 4.01..."

I set the fee to 5 and bump successfully.

Now again I am trying to bump it to 6.
Again getting this error that says "Required fee is 6.024..."

Screenshot:
Bump 008

Video:
https://github.com/SatoshiPortal/bullbitcoin-mobile/assets/701985/eee3fe22-c92e-4be9-a4be-d1623e3c4dfe

@i5hi
Copy link
Collaborator

i5hi commented Nov 27, 2023

must be a condition saying must be > n where it should be >=

@mocodesmo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants