Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Investigation: Tide Correction XY Points used to Predict Tides #222

Closed
2320sharon opened this issue Jan 26, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@2320sharon
Copy link
Collaborator

I received a report from a user that when the tide correction is applied to a session that didn't use the default transects the XY points don't reflect the seaward points of the transects in the session but instead appear to be the default transects. I don't know if this is true, but it needs to be investigated.

@2320sharon 2320sharon added the bug Something isn't working label Jan 26, 2024
@2320sharon 2320sharon self-assigned this Jan 26, 2024
@2320sharon 2320sharon changed the title Bug Investigation Bug Investigation: Tide Correction XY Points used to Predict Tides Jan 26, 2024
@2320sharon
Copy link
Collaborator Author

2320sharon commented Jan 26, 2024

image

Here is the user report along with an image of what they saw when they loaded the XY points from the csv into ARC. The points on the figure are the seaward points used to predict the tides for each of the transects. As you can see the points in the figure don't match the seaward points of the transects in the figure

I did not use the default coastseg transects for shoreline extraction b/c they were too short, were flipped, and the numbering wasn't sequential. For the tidal correction, does coastseg take the default transects for the region to do the tidal correction? I'm thinking that the default transects were used instead of my edited transects. I don't think it really matters that the tidal correction locations aren't at the seaward end of the transects (but correct me if I'm wrong).

@2320sharon
Copy link
Collaborator Author

After diving into the tide correction workflow. I'm not sure exactly what caused this exact bug but I think that it has to do with the XY columns used in the seaward points that are used to predict the tides. Instead of creating these 2 columns the XY points should just be read from the geometry which :

  • CRS transformations easier
  • wastes less space
  • make the operations faster
  • less confusing

I will keep the behavior where an XY point is saved to the tide corrected file for now.

2320sharon added a commit that referenced this issue Jan 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2320sharon added a commit that referenced this issue Jan 30, 2024
2320sharon added a commit that referenced this issue Feb 6, 2024
2320sharon added a commit that referenced this issue Feb 6, 2024
@2320sharon
Copy link
Collaborator Author

Closed in version 1.1.30

@github-project-automation github-project-automation bot moved this from Todo to Done in CoastSeg Project Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant