Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Animation to User Testimonials like in Top-Rented Items #12

Open
AmanKumar1115 opened this issue Oct 2, 2024 · 10 comments
Open

Add Animation to User Testimonials like in Top-Rented Items #12

AmanKumar1115 opened this issue Oct 2, 2024 · 10 comments

Comments

@AmanKumar1115
Copy link
Contributor

@SaranshBangar Can you assign it to me under gssoc-ext and hactober fest and level

@SaranshBangar
Copy link
Owner

@AmanKumar1115 please share some sample videos so I can gauge the difficulty and add the relevant tags

@AmanKumar1115
Copy link
Contributor Author

vedio.mp4

@SaranshBangar I can Add this if you assign me

@SaranshBangar
Copy link
Owner

It doesn't look that good to be honest, can you try something new?

@AmanKumar1115
Copy link
Contributor Author

@SaranshBangar
Do ignore the lighting and check for animation

test.mp4

please assign this issue to me with gssoc-ext, hactoberfest and level

@SaranshBangar
Copy link
Owner

@AmanKumar1115 It looks much better now, can you just add a bit of margin between the image and the user name please, then you can raise the PR

@AmanKumar1115
Copy link
Contributor Author

@AmanKumar1115 It looks much better now, can you just add a bit of margin between the image and the user name please, then you can raise the PR

Please assign this to me under label of gssoc-ext , hactoberfest and level

@SaranshBangar
Copy link
Owner

@AmanKumar1115 It looks much better now, can you just add a bit of margin between the image and the user name please, then you can raise the PR

Please assign this to me under label of gssoc-ext , hactoberfest and level

Done 👍🏼

@AmanKumar1115
Copy link
Contributor Author

@AmanKumar1115 It looks much better now, can you just add a bit of margin between the image and the user name please, then you can raise the PR

Please assign this to me under label of gssoc-ext , hactoberfest and level

Done 👍🏼

Please give this level 2 as I have added animation with no errors

@SaranshBangar
Copy link
Owner

@AmanKumar1115 It looks much better now, can you just add a bit of margin between the image and the user name please, then you can raise the PR

Please assign this to me under label of gssoc-ext , hactoberfest and level

Done 👍🏼

Please give this level 2 as I have added animation with no errors

I am really sorry but that would be against the spirit GSSoC 😅
You can raise a bigger issue and I can label it as Level 2 or Level 3

@SupriyaGo
Copy link

is this issue still available @SaranshBangar ? I can redesign the cards in a nicely manner if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants