You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The statement “print_error("Memory Allocation problem");” is specified in three branches for the implementation of the function “verify_write”.
I find that the message should be sufficient at one source code place.
💭 This could be achieved if a corresponding jump label like “report_allocation_failure” will be applied, couldn't it?
The text was updated successfully, but these errors were encountered:
Ok , will be done
Regards
Arthur
From: Markus Elfring ***@***.***>
Sent: Wednesday, June 29, 2022 5:22 PM
To: westerndigitalcorporation/ufs-utils ***@***.***>
Cc: Arthur Simchaev ***@***.***>; Comment ***@***.***>
Subject: Re: [westerndigitalcorporation/ufs-utils] Reduce duplicate code for exception handling (Issue #37)
CAUTION: This email originated from outside of Western Digital. Do not click on links or open attachments unless you recognize the sender and know that the content is safe.
💭 I would find it nice if you could integrate the proposed change possibilitiy also directly (without another separate pull/merge request from me).
—
Reply to this email directly, view it on GitHub<#37 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALE5422Z3VTFSYRGDGRCHRDVRRLYVANCNFSM52CNTGKQ>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
The statement “
print_error("Memory Allocation problem");
” is specified in three branches for the implementation of the function “verify_write”.I find that the message should be sufficient at one source code place.
💭 This could be achieved if a corresponding jump label like “
report_allocation_failure
” will be applied, couldn't it?The text was updated successfully, but these errors were encountered: