Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cynara-tests should not depend on en_US.UTF8 #10

Open
pohly opened this issue May 29, 2015 · 3 comments
Open

cynara-tests should not depend on en_US.UTF8 #10

pohly opened this issue May 29, 2015 · 3 comments

Comments

@pohly
Copy link
Contributor

pohly commented May 29, 2015

With the following change I get parser.getKeyAndValue to pass also on a system which has no
en_US.UTF8 locale:
sed -i -e 's/std::locale("en_US.UTF8")/std::locale("C")/g' ${S}/test/credsCommons/parser/Parser.cpp

As far as I can see at a glance, the test does not really depend on the en_US.UTF-8 locale (strings all plain ASCII?!), so this shouldn't change anything.

@JacquesBurac
Copy link
Contributor

Yes, you are right - these are just ASCII strings. Creating UTF-8 locale object is an overkill.
However, I suggest to use std::locale::classic() function instead of std::locale("C").

@pohly
Copy link
Contributor Author

pohly commented Jun 2, 2015

I've tried std::locale::classic() and that also works. I suggest that you just go ahead and commit a change created with sed. There's not much value in preparing a full patch.

@JacquesBurac
Copy link
Contributor

Fix pushed to:
https://review.tizen.org/gerrit/#/c/41355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants