Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverb not working as expected? #8

Open
sevgit opened this issue Mar 3, 2020 · 0 comments
Open

Reverb not working as expected? #8

sevgit opened this issue Mar 3, 2020 · 0 comments

Comments

@sevgit
Copy link

sevgit commented Mar 3, 2020

Hey, I've been toying around with this for a presentation, but I can't seem to make the reverb work even after trying a couple of different IR files (.wav).

Since I've been implementing most of the stuff myself, the only thing I'm using form the lib are the effects (particularly Distortion, Tremolo and Reverb), meaning I'm manually handling the connections and I'm not using the Output or Input classes provided by the lib.

class Mixer {
public reverb: IEffect;

    constructor() {
        this.reverb = { status: false, effect: new Reverb(this.audioContext) };
        fetch('./src/ir-files/baptist-church-nashville.wav')
            .then(response => response.arrayBuffer())
            .then(audioBuffer => this.reverb.effect.buffer = audioBuffer);
        this.reverb.effect.wet = 1;
        this.reverb.effect.level = 1;

...

I'm guessing the decoding of the arrayBuffer is not needed as the Reverb.js file seems to have it sorted on the setter, should I also omit making it an arrayBuffer in the first place?

The lib is a bit old but I got here after watching your live presentation and it has inspired some ideas for mine. Hope you can share some thoughts on how to solve this issue. Cheers!

Edit: as an extra bit of info, the sound does come out, only the Reverb doesn't work. I've tested using some Anechoic audio files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant