Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max speed has incorrect units (seemingly in DB) I think? #335

Closed
jat255 opened this issue Mar 23, 2023 · 2 comments
Closed

Max speed has incorrect units (seemingly in DB) I think? #335

jat255 opened this issue Mar 23, 2023 · 2 comments

Comments

@jat255
Copy link
Contributor

jat255 commented Mar 23, 2023

I had been wondering about this for a while, because I'd noticed that the "max speed" shown on a Workout page has always been rather off. I figured this had something to do with GPX parsing, but looking more into it, I think the data is getting written into the DB column max_speed in imperial units, and then getting "converted" from metric back to imperial on display, resulting in an incorrect number. This seems to also affects records, but seems to only impact rides (and not hikes or walks), as far as I can tell...

Here's some examples from my instance:

Correct? Activity type Max speed of activity on Strava Max speed shown in FT max_speed for workout in DB
Ride 33.5 mi/h 19.37 mi/h 31.17
Ride 29.0 mi/h 18.7 mi/h 30.09
Hike 3.78 mi/h 3.95 mi/h 6.35

First ride from table in FT:

image

Same in Strava (I loaded the gpx from Strava into FT, so they should be mostly the same, apart from maybe some smoothing):

image

@SamR1
Copy link
Owner

SamR1 commented Apr 8, 2023

Hi,

The issue seems to be related to extreme values exclusion by gpxpy, see #48

@jat255
Copy link
Contributor Author

jat255 commented May 10, 2023

Yes, I think you're right. I'll close this one since I think it's just that max-speed parsing thing messing things up.

@jat255 jat255 closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants