Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatSlider - MatNumeric Maximum, Minimum and Step. #746

Open
enkodellc opened this issue Oct 8, 2020 · 2 comments
Open

MatSlider - MatNumeric Maximum, Minimum and Step. #746

enkodellc opened this issue Oct 8, 2020 · 2 comments
Assignees
@sramaswami11
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@enkodellc
Copy link
Collaborator

enkodellc commented Oct 8, 2020 •
edited
Loading

Referring to how the other components do it but MatSlider is ValueMax / ValueMin / Step & MatNumeric is Maximum, Minimum and Step.

I would like to see it consistent across the components or since we only have 2 instances of "Max/Min/Step" that I found we can refer to material.io for the tie breaker?

Material-UI uses step, min, max for their Slider - Which I think is best and suggest refactoring the Slider and MatNumeric for this. Not in this PR.

Refer to #725
@enkodellc enkodellc added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request labels Oct 8, 2020
@sramaswami11
Copy link

@enkodellc I can work on this, Could you please assign this to me?

@sramaswami11
Copy link

@enkodellc , Created the following PR with the required code changes:
#877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sramaswami11 sramaswami11

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enkodellc @sramaswami11