Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature help stabilization #1071

Open
Saghen opened this issue Jan 23, 2025 · 6 comments
Open

Signature help stabilization #1071

Saghen opened this issue Jan 23, 2025 · 6 comments
Labels
feature New feature or request signature Related to the signature help

Comments

@Saghen
Copy link
Owner

Saghen commented Jan 23, 2025

Feature Description

  • Align the active argument with the argument in the text, grabbed via treesitter
  • Detect location of function to optionally avoid showing signature help in multi-line functions
  • Support focusing the window
  • Toggle visibility of documentation + signature vs just signature
  • Override built in vim.lsp.buf.signature_help()?
@Saghen Saghen added feature New feature or request signature Related to the signature help labels Jan 23, 2025
@Saghen Saghen pinned this issue Jan 23, 2025
@sebszyller
Copy link

On 0.11,

signature = {
	enabled = true,
	trigger = {
		enabled = false,
		show_on_trigger_character = false,
		show_on_insert_on_trigger_character = false,
	},
},

still auto-shows whenever blink gets to something that has a signature. Not sure if a bug or intended behaviour right now.
What I'm after is for the signature to show up exclusively when I invoke it with a keymap -- like I would for vim.lsp.buf.signature_help()

@silvercircle
Copy link

Support focusing the window
Override built in vim.lsp.buf.signature_help()?

These two would be particularly nice, or just an API function to manually activate the signature window. With some LSPs, this window can grow quite large so I don't want it to be always visible.

@Saghen
Copy link
Owner Author

Saghen commented Jan 31, 2025

You can show the window with cmp.show_signature() already fyi and it's now bound to <C-k>

@silvercircle
Copy link

You can show the window with cmp.show_signature() already fyi and it's now bound to <C-k>

Oh, didn't know that. Works fine, even as a toggle with hide_signature. Thanks, that's basically all I need.

@sebszyller
Copy link

sebszyller commented Jan 31, 2025

You can show the window with cmp.show_signature() already fyi and it's now bound to <C-k>

Is it intended that the signature always auto-shows right now though (when enabled as in the config above)? <C-k> is cool if I want to show it, after I hide it. But there doesn't seem to be a way to keep it hidden by default, and only toggle it on with a keymap.

@Saghen
Copy link
Owner Author

Saghen commented Jan 31, 2025

That's not intended no, I'll look into it soon. Just been lacking time for this project recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request signature Related to the signature help
Projects
None yet
Development

No branches or pull requests

3 participants