Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-select remove option once selected #6840

Open
1 task done
Harveyhoward opened this issue Jul 18, 2024 · 4 comments
Open
1 task done

Multi-select remove option once selected #6840

Harveyhoward opened this issue Jul 18, 2024 · 4 comments

Comments

@Harveyhoward
Copy link

Description

The multi select component when interacted with drops down all potential options. Once an option is selected from the drop down it is added to the "please select field" but remains an unusable option in the dropdown list.
I would expect that once an options is selected it is removed from the options list.
Why? If a user has a number of options with similar names it can become confusing to know which had been added, shortening the options list dynamically resolves this.

Reproduction

https://carbon.sage.com/?path=/docs/select-multiselect--docs

Steps to reproduce

No response

JIRA ticket numbers (Sage only)

No response

Suggested solution

No response

Carbon version

125.1.1

Design tokens version

No response

Relevant browsers

Chrome, Safari

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@Harveyhoward Harveyhoward added Bug triage Triage Required labels Jul 18, 2024
@edleeks87
Copy link
Contributor

@harpalsingh @ljemmo we discussed this on slack with @Harveyhoward and @tempertemper (I'll send the thread to you on there). Is this something DS/product want to add? We'd need to do I a fairly comprehensive rewrite as the current iteration relies heavily on the selected options being in the list to generate the Pill values so if it's a yes it might be more manageable to include this feature in the future rewrite we do for our Select components but in the interim we wondered if adding some form of option highlighting might be a good addition for now (see below for examples in other libs)?

https://mui.com/material-ui/react-select/#multiple-select
https://ant.design/~demos/select-demo-automatic-tokenization

@edleeks87 edleeks87 added the Design System Review Required DS team to review changes label Jul 18, 2024
@ljemmo
Copy link
Contributor

ljemmo commented Jul 19, 2024

@edleeks87 on my end i'll create a ticket for us to review the entire component and get back to you with a review. @ingridzillinger FYI.

open issue for you guys here: number 74 on DS board

@edleeks87
Copy link
Contributor

No problem we're happy to wait for the outcome of the above to be decided

@nicktitchmarsh
Copy link
Contributor

FE-6311

@nicktitchmarsh nicktitchmarsh added On Backlog and removed triage Triage Required Blocked Design System Review Required DS team to review changes labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants