From df4bb232693a3114721d4b55aa6a840a53650444 Mon Sep 17 00:00:00 2001 From: Jay Hodgson Date: Mon, 9 Dec 2024 13:10:32 -0800 Subject: [PATCH 1/2] SWC-7208: Fix SRC integration issue - variable name and type --- .../sagebionetworks/web/client/jsinterop/ErrorPageProps.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/sagebionetworks/web/client/jsinterop/ErrorPageProps.java b/src/main/java/org/sagebionetworks/web/client/jsinterop/ErrorPageProps.java index 2550633e56..9719861a9b 100644 --- a/src/main/java/org/sagebionetworks/web/client/jsinterop/ErrorPageProps.java +++ b/src/main/java/org/sagebionetworks/web/client/jsinterop/ErrorPageProps.java @@ -11,7 +11,7 @@ public class ErrorPageProps extends ReactComponentProps { String type; String message; String entityId; - Double entityVersionNumber; + double entityVersion; @JsFunction public interface Callback { @@ -32,7 +32,8 @@ public static ErrorPageProps create( props.type = type; props.message = message; props.entityId = entityId; - props.entityVersionNumber = + + props.entityVersion = entityVersion != null ? entityVersion.doubleValue() : null; props.gotoPlace = gotoPlace; return props; From fb4657a16b26864cef45f1616591dfeb7da2d148 Mon Sep 17 00:00:00 2001 From: Jay Hodgson Date: Mon, 9 Dec 2024 13:14:08 -0800 Subject: [PATCH 2/2] do not assign null to double --- .../web/client/jsinterop/ErrorPageProps.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/sagebionetworks/web/client/jsinterop/ErrorPageProps.java b/src/main/java/org/sagebionetworks/web/client/jsinterop/ErrorPageProps.java index 9719861a9b..15609f9761 100644 --- a/src/main/java/org/sagebionetworks/web/client/jsinterop/ErrorPageProps.java +++ b/src/main/java/org/sagebionetworks/web/client/jsinterop/ErrorPageProps.java @@ -32,9 +32,9 @@ public static ErrorPageProps create( props.type = type; props.message = message; props.entityId = entityId; - - props.entityVersion = - entityVersion != null ? entityVersion.doubleValue() : null; + if (entityVersion != null) { + props.entityVersion = entityVersion.doubleValue(); + } props.gotoPlace = gotoPlace; return props; }