From 54f10b685841e5d9f813633ee7bcfe217249ea23 Mon Sep 17 00:00:00 2001 From: Jin Jun Oh Date: Wed, 21 Feb 2024 15:50:19 -0800 Subject: [PATCH 1/2] SWC-6668A: delete legacy SqlDefinedEditor component, its occurances, and tests --- .../web/client/PortalGinInjector.java | 3 - .../web/client/PortalGinModule.java | 4 - .../EntityActionControllerImpl.java | 39 ---- .../modal/fileview/SqlDefinedTableEditor.java | 130 -------------- .../fileview/SqlDefinedTableEditorView.java | 25 --- .../SqlDefinedTableEditorViewImpl.java | 152 ---------------- .../EntityActionControllerImplTest.java | 1 - .../SqlDefinedTableEditorViewTest.java | 170 ------------------ 8 files changed, 524 deletions(-) delete mode 100755 src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditor.java delete mode 100644 src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorView.java delete mode 100644 src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorViewImpl.java delete mode 100644 src/test/java/org/sagebionetworks/web/unitclient/widget/table/modal/fileview/SqlDefinedTableEditorViewTest.java diff --git a/src/main/java/org/sagebionetworks/web/client/PortalGinInjector.java b/src/main/java/org/sagebionetworks/web/client/PortalGinInjector.java index a89edc7abb..288f722075 100644 --- a/src/main/java/org/sagebionetworks/web/client/PortalGinInjector.java +++ b/src/main/java/org/sagebionetworks/web/client/PortalGinInjector.java @@ -199,7 +199,6 @@ import org.sagebionetworks.web.client.widget.table.explore.TableEntityWidgetV2; import org.sagebionetworks.web.client.widget.table.modal.download.DownloadTableQueryModalWidget; import org.sagebionetworks.web.client.widget.table.modal.fileview.CreateTableViewWizard; -import org.sagebionetworks.web.client.widget.table.modal.fileview.SqlDefinedTableEditor; import org.sagebionetworks.web.client.widget.table.modal.fileview.ViewDefaultColumns; import org.sagebionetworks.web.client.widget.table.modal.upload.UploadTableModalWidget; import org.sagebionetworks.web.client.widget.table.v2.QueryTokenProvider; @@ -763,8 +762,6 @@ public interface PortalGinInjector extends Ginjector { CreateDatasetOrCollection getCreateDatasetOrCollection(); - SqlDefinedTableEditor getSqlDefinedTableEditor(); - UploadTableModalWidget getUploadTableModalWidget(); SqlDefinedEditorModalWidget getSqlDefinedEditorModalWidget(); diff --git a/src/main/java/org/sagebionetworks/web/client/PortalGinModule.java b/src/main/java/org/sagebionetworks/web/client/PortalGinModule.java index 72d141fea3..d41eebe16c 100644 --- a/src/main/java/org/sagebionetworks/web/client/PortalGinModule.java +++ b/src/main/java/org/sagebionetworks/web/client/PortalGinModule.java @@ -616,8 +616,6 @@ import org.sagebionetworks.web.client.widget.table.modal.fileview.EntityContainerListWidgetViewImpl; import org.sagebionetworks.web.client.widget.table.modal.fileview.EntityViewScopeWidgetView; import org.sagebionetworks.web.client.widget.table.modal.fileview.EntityViewScopeWidgetViewImpl; -import org.sagebionetworks.web.client.widget.table.modal.fileview.SqlDefinedTableEditorView; -import org.sagebionetworks.web.client.widget.table.modal.fileview.SqlDefinedTableEditorViewImpl; import org.sagebionetworks.web.client.widget.table.modal.fileview.SubmissionViewScopeWidgetView; import org.sagebionetworks.web.client.widget.table.modal.fileview.SubmissionViewScopeWidgetViewImpl; import org.sagebionetworks.web.client.widget.table.modal.fileview.ViewDefaultColumns; @@ -1446,8 +1444,6 @@ protected void configure() { bind(ContainerClientsHelp.class).to(ContainerClientsHelpImpl.class); bind(FileDownloadMenuItemView.class).to(FileDownloadMenuItemViewImpl.class); - bind(SqlDefinedTableEditorView.class) - .to(SqlDefinedTableEditorViewImpl.class); bind(SqlDefinedEditorModalWidgetView.class) .to(SqlDefinedEditorModalWidgetViewImpl.class); bind(ChallengeWidgetView.class).to(ChallengeWidgetViewImpl.class); diff --git a/src/main/java/org/sagebionetworks/web/client/widget/entity/controller/EntityActionControllerImpl.java b/src/main/java/org/sagebionetworks/web/client/widget/entity/controller/EntityActionControllerImpl.java index b5c8f650a9..790502372b 100755 --- a/src/main/java/org/sagebionetworks/web/client/widget/entity/controller/EntityActionControllerImpl.java +++ b/src/main/java/org/sagebionetworks/web/client/widget/entity/controller/EntityActionControllerImpl.java @@ -128,7 +128,6 @@ import org.sagebionetworks.web.client.widget.sharing.AccessControlListModalWidget; import org.sagebionetworks.web.client.widget.statistics.StatisticsPlotWidget; import org.sagebionetworks.web.client.widget.table.modal.fileview.CreateTableViewWizard; -import org.sagebionetworks.web.client.widget.table.modal.fileview.SqlDefinedTableEditor; import org.sagebionetworks.web.client.widget.table.modal.fileview.TableType; import org.sagebionetworks.web.client.widget.table.modal.upload.UploadTableModalWidget; import org.sagebionetworks.web.client.widget.table.modal.wizard.ModalWizardWidget.WizardCallback; @@ -276,7 +275,6 @@ public class EntityActionControllerImpl AddFolderDialogWidget addFolderDialogWidget; CreateTableViewWizard createTableViewWizard; CreateDatasetOrCollection createDatasetOrCollection; - SqlDefinedTableEditor sqlDefinedTableEditor; SqlDefinedEditorModalWidget sqlDefinedEditorModalWidget; boolean isShowingVersion = false; WizardCallback entityUpdatedWizardCallback; @@ -439,14 +437,6 @@ private AccessControlListModalWidget getAccessControlListModalWidget() { return accessControlListModalWidget; } - private SqlDefinedTableEditor getSqlDefinedTableEditor() { - if (sqlDefinedTableEditor == null) { - sqlDefinedTableEditor = ginInjector.getSqlDefinedTableEditor(); - this.view.addWidget(sqlDefinedTableEditor.asWidget()); - } - return sqlDefinedTableEditor; - } - private CreateTableViewWizard getCreateTableViewWizard() { if (createTableViewWizard == null) { createTableViewWizard = ginInjector.getCreateTableViewWizard(); @@ -1971,35 +1961,6 @@ public void onAddTable() { ); } - public void onAddMaterializedView() { - preflightController.checkCreateEntity( - entityBundle, - MaterializedView.class.getName(), - () -> { - // to create a MaterializedView, we need to know the definingSQL - getSqlDefinedTableEditor() - .configure( - entityBundle.getEntity().getId(), - EntityType.materializedview - ) - .show(); - } - ); - } - - public void onAddVirtualTable() { - preflightController.checkCreateEntity( - entityBundle, - VirtualTable.class.getName(), - () -> { - // to create a MaterializedView, we need to know the definingSQL - getSqlDefinedTableEditor() - .configure(entityBundle.getEntity().getId(), EntityType.virtualtable) - .show(); - } - ); - } - private void postCheckCreateDatasetOrCollection(TableType type) { CreateDatasetOrCollection dialog = getCreateDatasetOrCollection(); dialog.configure(entityBundle.getEntity().getId(), type); diff --git a/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditor.java b/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditor.java deleted file mode 100755 index 2e55493b9e..0000000000 --- a/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditor.java +++ /dev/null @@ -1,130 +0,0 @@ -package org.sagebionetworks.web.client.widget.table.modal.fileview; - -import static com.google.common.util.concurrent.MoreExecutors.directExecutor; - -import com.google.common.util.concurrent.FutureCallback; -import com.google.gwt.user.client.ui.IsWidget; -import com.google.gwt.user.client.ui.Widget; -import com.google.inject.Inject; -import org.sagebionetworks.repo.model.Entity; -import org.sagebionetworks.repo.model.EntityType; -import org.sagebionetworks.repo.model.EntityTypeUtils; -import org.sagebionetworks.repo.model.table.HasDefiningSql; -import org.sagebionetworks.repo.model.table.MaterializedView; -import org.sagebionetworks.repo.model.table.Table; -import org.sagebionetworks.repo.model.table.VirtualTable; -import org.sagebionetworks.web.client.GlobalApplicationState; -import org.sagebionetworks.web.client.PopupUtilsView; -import org.sagebionetworks.web.client.SynapseJavascriptClient; -import org.sagebionetworks.web.client.place.Synapse; -import org.sagebionetworks.web.client.widget.entity.controller.SynapseAlert; -import org.sagebionetworks.web.shared.WebConstants; - -public class SqlDefinedTableEditor - implements SqlDefinedTableEditorView.Presenter, IsWidget { - - public static final String VIEW_URL = - WebConstants.DOCS_URL + "Views.2011070739.html"; - - public static final String MATERIALIZED_VIEW_HELP_MARKDOWN = - "A Synapse Materialized View is a type of table that is automatically built from a Synapse SQL query. " + - "The defining SQL of a Materialized View can contain JOIN clauses to combine data from multiple tables."; - - public static final String VIRTUAL_TABLE_HELP_MARKDOWN = - "A Synapse Virtual Table is a type of table that is defined by a Synapse SQL query. " + - "Any query on a Virtual Table will execute the defining SQL statement on the referenced table. " + - "The defining SQL of a Virtual Table cannot include JOIN clauses on multiple tables."; - SynapseAlert synAlert; - SqlDefinedTableEditorView view; - SynapseJavascriptClient jsClient; - GlobalApplicationState globalAppState; - PopupUtilsView popupUtils; - String parentEntityId; - EntityType entityType; - - @Inject - public SqlDefinedTableEditor( - SqlDefinedTableEditorView view, - SynapseJavascriptClient jsClient, - SynapseAlert synAlert, - GlobalApplicationState globalAppState - ) { - this.view = view; - this.jsClient = jsClient; - this.globalAppState = globalAppState; - this.synAlert = synAlert; - this.view.setPresenter(this); - view.setSynAlert(synAlert); - } - - public SqlDefinedTableEditor configure( - String parentEntityId, - EntityType entityType - ) { - if (EntityType.materializedview.equals(entityType)) { - view.setHelp(MATERIALIZED_VIEW_HELP_MARKDOWN, VIEW_URL); - } else if (EntityType.virtualtable.equals(entityType)) { - view.setHelp(VIRTUAL_TABLE_HELP_MARKDOWN, VIEW_URL); - } else { - throw new IllegalArgumentException( - "Expected MaterializedView or VirtualTable but got " + - entityType.toString() - ); - } - - view.setModalTitle("Create " + EntityTypeUtils.getDisplayName(entityType)); - - this.parentEntityId = parentEntityId; - this.entityType = entityType; - synAlert.clear(); - view.reset(); - return this; - } - - public void show() { - view.show(); - } - - @Override - public Widget asWidget() { - return view.asWidget(); - } - - @Override - public void onSave() { - // create the table - Table newEntity; - if (EntityType.materializedview.equals(this.entityType)) { - newEntity = new MaterializedView(); - } else if (EntityType.virtualtable.equals(this.entityType)) { - newEntity = new VirtualTable(); - } else { - throw new IllegalArgumentException( - "Expected MaterializedView or VirtualTable but got " + - entityType.toString() - ); - } - newEntity.setName(view.getName()); - newEntity.setDescription(view.getDescription()); - ((HasDefiningSql) newEntity).setDefiningSQL(view.getDefiningSql()); - newEntity.setParentId(parentEntityId); - synAlert.clear(); - jsClient - .createEntity(newEntity) - .addCallback( - new FutureCallback() { - @Override - public void onSuccess(Entity entity) { - view.hide(); - globalAppState.getPlaceChanger().goTo(new Synapse(entity.getId())); - } - - @Override - public void onFailure(Throwable caught) { - synAlert.handleException(caught); - } - }, - directExecutor() - ); - } -} diff --git a/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorView.java b/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorView.java deleted file mode 100644 index 78c6df3814..0000000000 --- a/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorView.java +++ /dev/null @@ -1,25 +0,0 @@ -package org.sagebionetworks.web.client.widget.table.modal.fileview; - -import com.google.gwt.user.client.ui.IsWidget; - -public interface SqlDefinedTableEditorView extends IsWidget { - String getName(); - void setName(String name); - String getDescription(); - void setDescription(String description); - String getDefiningSql(); - void setModalTitle(String title); - void setDefiningSql(String definingSql); - void setHelp(String helpMarkdown, String helpUrl); - void setSynAlert(IsWidget w); - void setLoading(boolean loading); - void show(); - void hide(); - void reset(); - - public interface Presenter { - void onSave(); - } - - void setPresenter(Presenter presenter); -} diff --git a/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorViewImpl.java b/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorViewImpl.java deleted file mode 100644 index 6855cac732..0000000000 --- a/src/main/java/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorViewImpl.java +++ /dev/null @@ -1,152 +0,0 @@ -package org.sagebionetworks.web.client.widget.table.modal.fileview; - -import com.google.gwt.uibinder.client.UiBinder; -import com.google.gwt.uibinder.client.UiField; -import com.google.gwt.user.client.ui.IsWidget; -import com.google.gwt.user.client.ui.Widget; -import com.google.inject.Inject; -import org.gwtbootstrap3.client.ui.Button; -import org.gwtbootstrap3.client.ui.FormGroup; -import org.gwtbootstrap3.client.ui.Heading; -import org.gwtbootstrap3.client.ui.Modal; -import org.gwtbootstrap3.client.ui.TextArea; -import org.gwtbootstrap3.client.ui.TextBox; -import org.gwtbootstrap3.client.ui.html.Div; -import org.gwtbootstrap3.client.ui.html.Span; -import org.sagebionetworks.web.client.DisplayUtils; -import org.sagebionetworks.web.client.cookie.CookieProvider; -import org.sagebionetworks.web.client.widget.HelpWidget; - -public class SqlDefinedTableEditorViewImpl - implements SqlDefinedTableEditorView { - - public interface Binder - extends UiBinder {} - - @UiField - Heading modalHeading; - - @UiField - TextBox nameField; - - @UiField - FormGroup descriptionFormGroup; - - @UiField - TextArea descriptionField; - - @UiField - TextArea definingSqlField; - - @UiField - Span helpContainer; - - @UiField - Div synapseAlertContainer; - - @UiField - Button primaryButton; - - @UiField - Button defaultButton; - - Modal modal; - Presenter p; - - @Inject - public SqlDefinedTableEditorViewImpl(Binder binder, CookieProvider cookies) { - modal = (Modal) binder.createAndBindUi(this); - // This constructor won't re-run unless the page is refreshed, so the FormGroup won't be visible after enabling Experimental Mode w/o a refresh - descriptionFormGroup.setVisible(DisplayUtils.isInTestWebsite(cookies)); - defaultButton.addClickHandler(event -> { - modal.hide(); - }); - primaryButton.addClickHandler(event -> { - p.onSave(); - }); - } - - @Override - public Widget asWidget() { - return modal; - } - - @Override - public String getName() { - return nameField.getText(); - } - - @Override - public void setName(String name) { - nameField.setText(name); - } - - @Override - public String getDescription() { - return descriptionField.getText(); - } - - @Override - public void setDescription(String description) { - descriptionField.setText(description); - } - - @Override - public void setDefiningSql(String definingSql) { - definingSqlField.setText(definingSql); - } - - @Override - public String getDefiningSql() { - return definingSqlField.getText(); - } - - @Override - public void setModalTitle(String title) { - modalHeading.setText(title); - } - - @Override - public void setHelp(String helpMarkdown, String helpUrl) { - helpContainer.clear(); - HelpWidget help = new HelpWidget(); - help.setHref(helpUrl); - help.setHelpMarkdown(helpMarkdown); - help.setAddStyleNames("margin-left-5"); - helpContainer.add(help); - } - - @Override - public void setSynAlert(IsWidget w) { - synapseAlertContainer.clear(); - synapseAlertContainer.add(w); - } - - @Override - public void setPresenter(Presenter presenter) { - p = presenter; - } - - @Override - public void setLoading(boolean loading) { - primaryButton.setEnabled(!loading); - } - - @Override - public void show() { - modal.show(); - } - - @Override - public void hide() { - modal.hide(); - } - - @Override - public void reset() { - nameField.setText(""); - descriptionField.setText(""); - definingSqlField.setText(""); - setLoading(false); - } -} diff --git a/src/test/java/org/sagebionetworks/web/unitclient/widget/entity/controller/EntityActionControllerImplTest.java b/src/test/java/org/sagebionetworks/web/unitclient/widget/entity/controller/EntityActionControllerImplTest.java index 7f32c89246..d255a7db30 100755 --- a/src/test/java/org/sagebionetworks/web/unitclient/widget/entity/controller/EntityActionControllerImplTest.java +++ b/src/test/java/org/sagebionetworks/web/unitclient/widget/entity/controller/EntityActionControllerImplTest.java @@ -167,7 +167,6 @@ import org.sagebionetworks.web.client.widget.evaluation.EvaluationSubmitter; import org.sagebionetworks.web.client.widget.sharing.AccessControlListModalWidget; import org.sagebionetworks.web.client.widget.table.modal.fileview.CreateTableViewWizard; -import org.sagebionetworks.web.client.widget.table.modal.fileview.SqlDefinedTableEditor; import org.sagebionetworks.web.client.widget.table.modal.fileview.TableType; import org.sagebionetworks.web.client.widget.table.modal.upload.UploadTableModalWidget; import org.sagebionetworks.web.client.widget.table.modal.wizard.ModalWizardWidget.WizardCallback; diff --git a/src/test/java/org/sagebionetworks/web/unitclient/widget/table/modal/fileview/SqlDefinedTableEditorViewTest.java b/src/test/java/org/sagebionetworks/web/unitclient/widget/table/modal/fileview/SqlDefinedTableEditorViewTest.java deleted file mode 100644 index 05c6fecbc5..0000000000 --- a/src/test/java/org/sagebionetworks/web/unitclient/widget/table/modal/fileview/SqlDefinedTableEditorViewTest.java +++ /dev/null @@ -1,170 +0,0 @@ -package org.sagebionetworks.web.unitclient.widget.table.modal.fileview; - -import static org.junit.Assert.assertEquals; -import static org.mockito.Matchers.any; -import static org.mockito.Mockito.validateMockitoUsage; -import static org.mockito.Mockito.verify; -import static org.mockito.Mockito.when; -import static org.sagebionetworks.web.client.utils.FutureUtils.getDoneFuture; -import static org.sagebionetworks.web.client.utils.FutureUtils.getFailedFuture; - -import org.junit.After; -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.mockito.ArgumentCaptor; -import org.mockito.Captor; -import org.mockito.Mock; -import org.mockito.runners.MockitoJUnitRunner; -import org.sagebionetworks.repo.model.Entity; -import org.sagebionetworks.repo.model.EntityType; -import org.sagebionetworks.repo.model.table.MaterializedView; -import org.sagebionetworks.repo.model.table.VirtualTable; -import org.sagebionetworks.web.client.GlobalApplicationState; -import org.sagebionetworks.web.client.PlaceChanger; -import org.sagebionetworks.web.client.SynapseJavascriptClient; -import org.sagebionetworks.web.client.place.Synapse; -import org.sagebionetworks.web.client.widget.entity.controller.SynapseAlert; -import org.sagebionetworks.web.client.widget.table.modal.fileview.SqlDefinedTableEditor; -import org.sagebionetworks.web.client.widget.table.modal.fileview.SqlDefinedTableEditorView; - -@RunWith(MockitoJUnitRunner.class) -public class SqlDefinedTableEditorViewTest { - - @Mock - SqlDefinedTableEditorView mockView; - - @Mock - SynapseJavascriptClient mockSynapseJavascriptClient; - - @Mock - SynapseAlert mockSynapseAlert; - - @Mock - GlobalApplicationState mockGlobalAppState; - - @Mock - PlaceChanger mockPlaceChanger; - - @Mock - MaterializedView mockMaterializedView; - - @Captor - ArgumentCaptor entityCaptor; - - SqlDefinedTableEditor widget; - - public static final String MATERIALIZED_VIEW_ID = "syn42"; - - @Before - public void before() { - widget = - new SqlDefinedTableEditor( - mockView, - mockSynapseJavascriptClient, - mockSynapseAlert, - mockGlobalAppState - ); - when(mockMaterializedView.getId()).thenReturn(MATERIALIZED_VIEW_ID); - when(mockSynapseJavascriptClient.createEntity(any(Entity.class))) - .thenReturn(getDoneFuture(mockMaterializedView)); - when(mockGlobalAppState.getPlaceChanger()).thenReturn(mockPlaceChanger); - } - - @After - public void validate() { - validateMockitoUsage(); - } - - @Test - public void testConstruction() { - verify(mockView).setPresenter(widget); - verify(mockView).setSynAlert(mockSynapseAlert); - } - - @Test - public void testHappyPathMaterializedView() { - String projectId = "syn112358"; - widget.configure(projectId, EntityType.materializedview).show(); - - verify(mockSynapseAlert).clear(); - verify(mockView).reset(); - verify(mockView).setModalTitle("Create Materialized View"); - verify(mockView) - .setHelp( - SqlDefinedTableEditor.MATERIALIZED_VIEW_HELP_MARKDOWN, - SqlDefinedTableEditor.VIEW_URL - ); - verify(mockView).show(); - - String name = "a new view"; - String definingSql = "select * from this join that"; - String description = "this describes my new materialized view"; - when(mockView.getName()).thenReturn(name); - when(mockView.getDefiningSql()).thenReturn(definingSql); - when(mockView.getDescription()).thenReturn(description); - - widget.onSave(); - - verify(mockSynapseJavascriptClient).createEntity(entityCaptor.capture()); - MaterializedView newMaterializedView = - (MaterializedView) entityCaptor.getValue(); - assertEquals(name, newMaterializedView.getName()); - assertEquals(definingSql, newMaterializedView.getDefiningSQL()); - assertEquals(description, newMaterializedView.getDescription()); - verify(mockView).hide(); - verify(mockPlaceChanger).goTo(any(Synapse.class)); - } - - @Test - public void testHappyPathVirtualTable() { - String projectId = "syn112358"; - widget.configure(projectId, EntityType.virtualtable).show(); - - verify(mockSynapseAlert).clear(); - verify(mockView).reset(); - verify(mockView).setModalTitle("Create Virtual Table"); - verify(mockView) - .setHelp( - SqlDefinedTableEditor.VIRTUAL_TABLE_HELP_MARKDOWN, - SqlDefinedTableEditor.VIEW_URL - ); - verify(mockView).show(); - - String name = "a new view"; - String definingSql = "select * from this join that"; - String description = "this describes my new virtual table"; - when(mockView.getName()).thenReturn(name); - when(mockView.getDefiningSql()).thenReturn(definingSql); - when(mockView.getDescription()).thenReturn(description); - - widget.onSave(); - - verify(mockSynapseJavascriptClient).createEntity(entityCaptor.capture()); - VirtualTable newVirtualTable = (VirtualTable) entityCaptor.getValue(); - assertEquals(name, newVirtualTable.getName()); - assertEquals(definingSql, newVirtualTable.getDefiningSQL()); - assertEquals(description, newVirtualTable.getDescription()); - verify(mockView).hide(); - verify(mockPlaceChanger).goTo(any(Synapse.class)); - } - - @Test - public void testFailedToSave() { - Throwable error = new Exception("something went wrong"); - when(mockSynapseJavascriptClient.createEntity(any(Entity.class))) - .thenReturn(getFailedFuture(error)); - widget.configure("", EntityType.materializedview); - - widget.onSave(); - - verify(mockSynapseJavascriptClient).createEntity(any()); - verify(mockSynapseAlert).handleException(error); - } - - @Test - public void testAsWidget() { - widget.asWidget(); - verify(mockView).asWidget(); - } -} From 6d5324fbc25c93cfbd8db33033fb5a07bd917036 Mon Sep 17 00:00:00 2001 From: Jin Jun Oh Date: Thu, 22 Feb 2024 10:09:20 -0800 Subject: [PATCH 2/2] SWC-6668A: delete SqlDefinedTableEditorViewImpl.ui.xml --- .../SqlDefinedTableEditorViewImpl.ui.xml | 52 ------------------- 1 file changed, 52 deletions(-) delete mode 100755 src/main/resources/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorViewImpl.ui.xml diff --git a/src/main/resources/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorViewImpl.ui.xml b/src/main/resources/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorViewImpl.ui.xml deleted file mode 100755 index a5c8c8d6b9..0000000000 --- a/src/main/resources/org/sagebionetworks/web/client/widget/table/modal/fileview/SqlDefinedTableEditorViewImpl.ui.xml +++ /dev/null @@ -1,52 +0,0 @@ - - - - - - - - - - - - Name - - - - Description - - - - Defining SQL - - - - - - - - - - - -