Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Remove custom classes #24

Open
vpchung opened this issue Apr 10, 2024 · 1 comment
Open

[bug] Remove custom classes #24

vpchung opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@vpchung
Copy link
Member

vpchung commented Apr 10, 2024

Error encountered

Not an error per se, but more of a concern on possible future confusion between classes from the synapseclient and classes created for cnb-tools. cnb-tools should instead act more of an extension by being a functional programming interface.

CC: @BryanFauble

Expected behavior

See this module as a reference on what an "extensions" package would look like.

@vpchung vpchung added the bug Something isn't working label Apr 10, 2024
@vpchung vpchung self-assigned this Apr 10, 2024
@BryanFauble
Copy link

An interesting way to think about this "extensions" package as well is to try and develop it with the ability to "plugin" another set of configuration files to drive your specific use case.

For example, If I were to change this create_folders function to meet that use-case I would write it in such a way that you could define the folder/sub-folder structure how you'd like it to look (But provide a default configuration too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants