Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Correct origins for CombinedCallGraphNodes #267

Closed
lukarade opened this issue May 2, 2024 · 0 comments · Fixed by #269
Closed

Correct origins for CombinedCallGraphNodes #267

lukarade opened this issue May 2, 2024 · 0 comments · Fixed by #269
Assignees
@lukarade
Labels
enhancement 💡 New feature or request purity Inferring the purity of functions

Comments

@lukarade
Copy link
Contributor

lukarade commented May 2, 2024

Is your feature request related to a problem?

Currently, the origins of the Reasons of nodes combined by a CombinedCallGraphNode are determined when the combined node is separated.
Sometimes the origin cannot be found and the combined NodeID is used instead.
This leads to very long results when the NodeID is stringified for the output json file.

Desired solution

Store the origin with the Symbol in the corresponding set of the Reasons object.
With this, every origin of each node in the CombinedCallGraphNodes can be determined.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lukarade lukarade added enhancement 💡 New feature or request purity Inferring the purity of functions labels May 2, 2024
@lukarade lukarade self-assigned this May 2, 2024
@lukarade lukarade mentioned this issue May 4, 2024
Merged
@lukarade lukarade linked a pull request May 4, 2024 that will close this issue
feat: correct origins for CombinedCallGraphNodes #269
Merged
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Analysis Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lukarade lukarade

Labels
enhancement 💡 New feature or request purity Inferring the purity of functions
Projects
Library Analysis
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: correct origins for CombinedCallGraphNodes Safe-DS/Library-Analyzer
1 participant
@lukarade