Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI stage throws errors if trying to exceed physical limits #469

Open
mkrumin opened this issue Jan 9, 2025 · 1 comment
Open

PI stage throws errors if trying to exceed physical limits #469

mkrumin opened this issue Jan 9, 2025 · 1 comment

Comments

@mkrumin
Copy link

mkrumin commented Jan 9, 2025

If the software limits in componentSettings.m exceed the physical limits of the PI stages and then trying to move beyond the physical limits (but within the software limits). The errors are thrown in the command window, although nothing crashes.
The behavior for the z-stage is different - it just prints the usual message of the 'limits exceeded'.

@raacampbell
Copy link
Collaborator

Would a suitable solution be:

  1. Silently honour whichever limit (software or hardware) is the smallest?
  2. If the software limit is larger than the hardware limit, print to the command line in some prominent way that this is the case when the motion class instantiates. The warning message would therefore appear once when BakingTray starts.

This is not ideal, because the user won't get feedback until the software is restarted. However it's the easiest thing to do. Another easy option would be to print the warning message to the CLI every time the limit is checked. This seems like it could be messy, though. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants