Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python-libteam package from docs #1540

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

tbazant
Copy link
Collaborator

@tbazant tbazant commented Jun 26, 2023

PR creator: Description

The package is no longer in supported repos

PR creator: Are there any relevant issues/feature requests?

  • bsc#1212159

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE 15/openSUSE Leap 15.x
    • SLE 15 next/openSUSE Leap next (current main, no backport necessary)
    • SLE 15 SP4/openSUSE Leap 15.5
    • SLE 15 SP4/openSUSE Leap 15.4
    • SLE 15 SP3/openSUSE Leap 15.3
    • SLE 15 SP2/openSUSE Leap 15.2
    • SLE 15 SP1
  • SLE 12
    • SLE 12 SP5
    • SLE 12 SP4

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

@tbazant tbazant self-assigned this Jun 26, 2023
Copy link
Contributor

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tbazant tbazant merged commit 9fc757e into main Jun 26, 2023
8 checks passed
@tbazant tbazant deleted the tbazant-remove-python-libteam-bsc#1212159 branch June 26, 2023 08:34
tbazant added a commit that referenced this pull request Jun 26, 2023
tbazant added a commit that referenced this pull request Jun 26, 2023
@cwickert
Copy link
Member

I think you did not look correctly. 👎

Please never list library packages by name.

  1. You don't have to, they will be pulled in automatically.
  2. If there is a soname bump for a new version, our instructions become incorrect.
localhost:~ # rpm -q --requires libteam-tools | grep libteam
config(libteam-tools) = 1.27-150000.4.6.1
libteam.so.5()(64bit)
libteamdctl.so.0()(64bit)
localhost:~ # rpm -q --whatprovides "libteamdctl.so.0()(64bit)"
libteamdctl0-1.27-150000.4.6.1.x86_64

As you can see, there is no need to list libteamdctl0.

If you write

Verify that the required packages libteam-tools and libteamdctl0 are installed.

you should tell people how to actually do this (rpm -q libteam-tools). Even simpler: Just tell them how to install it (AFAIK it's not installed by default). If it's already installed, zypper will tell you and if it's outdated, zypper will update it. Win-win!

That's what I did 59eb338

Let's please review things more carefully in the future.

@cwickert
Copy link
Member

For the record: I fixed all supported branches plus the smart doc article with SUSE/doc-modular@b1589bd

@tbazant
Copy link
Collaborator Author

tbazant commented Jun 26, 2023

For the record: I fixed all supported branches plus the smart doc article with SUSE/doc-modular@b1589bd

thanks @cwickert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants