Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in Public Distributed Api for all_to_all and gather_there #6544

Open
AndreyKulikov2022 opened this issue Sep 12, 2024 · 1 comment
Open

Comments

@AndreyKulikov2022
Copy link

Actual Behavior

In the actual signature of hpx::collectives::gather_there:

template <typename T>
    hpx::future<void> gather_there(communicator fid, T&& local_result,
        this_site_arg this_site = this_site_arg(),
        generation_arg generation = generation_arg())

the return type differs from the one described in Public Distributed Api:

 template <typename T>
    hpx::future<std::vector<decay_t<T>>>
    gather_there(communicator comm, T&& result,
        this_site_arg this_site = this_site_arg(),
        generation_arg generation = generation_arg());

The same is true for hpx::collectives::all_to_all:

template <typename T>
    hpx::future<std::vector<std::decay_t<T>>>
    all_to_all(char const* basename, T&& result,
        num_sites_arg num_sites = num_sites_arg(),
        this_site_arg this_site = this_site_arg(),
        generation_arg generation = generation_arg(),
        root_site_arg root_site = root_site_arg());

with the wrong local result parameter in Public Api:

template <typename T>
    hpx::future<std::vector<T>> all_to_all(communicator fid,
        std::vector<T>&& local_result,
        this_site_arg this_site = this_site_arg(),
        generation_arg generation = generation_arg())
@hkaiser
Copy link
Member

hkaiser commented Sep 12, 2024

@AndreyKulikov2022 thanks for reporting this. @dimitraka could you have a look, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants