Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal refs should go to the current Bible but currently go to the default Bible (ESV) #106

Open
DavidIB opened this issue May 26, 2022 · 0 comments

Comments

@DavidIB
Copy link
Contributor

DavidIB commented May 26, 2022

EG at
https://www.stepbible.org/?q=version=SpaNVI|reference=1Kgs.2&options=VUGVNH&display=INTERLEAVED
there are links to parallel passages.
image
Currently, if you click on them, they open in ESV.
THe link is
< a xref="1Ch 29:26-28" class="linkRef" title="1Ch 29:26-28" href="?q=version=ESV|reference=1Chr.29.26-1Chr.29.28">1Cr 29:26-28
but should be:
< a xref="1Ch 29:26-28" class="linkRef" title="1Ch 29:26-28" href="?q=version=SpaNVI....

The version isn't set by the OSIS module which has:

<hi type='italic'>
<reference osisRef='1Kgs.2.10-1Kgs.2.12'>2:10-12</reference> – 
<reference osisRef='1Chr.29.26-1Chr.29.28'>1Cr 29:26-28</reference>
 </hi>

So the version must be added within the STEPBible coding. It is probably set to the 'default' Bible, or perhaps specifically to ESV.
It should be set to the same Bible that the reference is found in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant