Merge branch '510558017' into lab5

Author: as10968574

.github/workflows/lab-autograding.yml

@@ -12,6 +12,7 @@ jobs:
                 os: [ubuntu-22.04]
             fail-fast: false
         steps:
+
             - name: Checkout repository
               uses: actions/checkout@v4
               with:
@@ -23,6 +24,15 @@ jobs:
               with:
                   node-version: '20'
 
+
+            - uses: actions/checkout@v4
+              with:
+                  ref: "${{ github.event.pull_request.merge_commit_sha }}"
+                  fetch-depth: 1
+            - uses: actions/setup-node@v4
+              with:
+                  node-version: latest
+
             - name: Extract lab number and Check no changes other than specific files
               uses: actions/github-script@v5
               id: lab
@@ -44,17 +54,28 @@ jobs:
                         return { number: 0 };
                       }
                       const labNumber = labNumberMatch[1];
+
                       console.log(`Lab number: ${labNumber}`);
 
+                      console.log(`Lab number: ${labNumber}`)
+
+
                       const files = await github.rest.pulls.listFiles({ owner, repo, pull_number: issue_number });
                       const changedFiles = files.data.map((file) => file.filename);
                       const allowedFileRegex = /^lab\d+\/main_test.js$/;
                       const specialChangedFiles = ["lab5/Answer.md", "lab5/antiasan.c", "lab6/Answer.md", "lab7/sol.py"];
+
                       if (!changedFiles.every((file) => allowedFileRegex.test(file) || specialChangedFiles.includes(file))) {
                         core.setFailed('The PR contains changes to files other than the allowed files.');
                       }
                       return labNumber;
 
+
+                      if (!changedFiles.every((file) => (allowedFileRegex.test(file) || specialChangedFiles.includes(file)))) {
+                        core.setFailed('The PR contains changes to files other than the allowed files.');
+                      }
+                      return labNumber;
+
             - name: Grading
               run: |
                   cd lab${{ steps.lab.outputs.result }}

lab1/main.js

@@ -42,14 +42,14 @@ class Student {
     }
 }
 
-// const myClass = new MyClass();
-// const names = ['John', 'Jane', 'Doe', 'Smith'];
-// names.forEach(name => {
-//     const student = new Student();
-//     student.setName(name);
-//     const newStudentId = myClass.addStudent(student);
-//     const newStudentName = myClass.getStudentById(newStudentId).getName();
-//     console.log('[+] Added student with id: %d, name: %s', newStudentId, newStudentName);
+ //const myClass = new MyClass();
+//const names = ['John', 'Jane', 'Doe', 'Smith'];
+//names.forEach(name => {
+    // const student = new Student();
+     //student.setName(name);
+   // const newStudentId = myClass.addStudent(student);
+     //const newStudentName = myClass.getStudentById(newStudentId).getName();
+  //  console.log('[+] Added student with id: %d, name: %s', newStudentId, newStudentName);
 // });
 
-module.exports = { MyClass, Student };
+module.exports = { MyClass, Student };

lab1/main_test.js

@@ -3,21 +3,39 @@ const assert = require('assert');
 const { MyClass, Student } = require('./main');
 
 test("Test MyClass's addStudent", () => {
-    // TODO
-    throw new Error("Test not implemented");
+    const myClass = new MyClass();
+    const student = new Student();
+    student.setName("John");
+    const index = myClass.addStudent(student);
+    assert.strictEqual(index, 0, "addStudent should return index 0 for the first student");
+    const notAStudent = {}; 
+    const indexForNotAStudent = myClass.addStudent(notAStudent);
+    assert.strictEqual(indexForNotAStudent, -1, "addStudent should return -1 when adding a non-Student instance");
 });
 
 test("Test MyClass's getStudentById", () => {
-    // TODO
-    throw new Error("Test not implemented");
+    const myClass = new MyClass();
+    const student = new Student();
+    student.setName("Jane");
+    const index = myClass.addStudent(student);
+    const fetchedStudent = myClass.getStudentById(index);
+    assert.strictEqual(fetchedStudent.getName(), "Jane", "getStudentById should retrieve the student with the correct name");
+    const invalidFetchedStudent = myClass.getStudentById(-1);
+    assert.strictEqual(invalidFetchedStudent, null, "getStudentById should return null for an invalid id");
 });
 
 test("Test Student's setName", () => {
-    // TODO
-    throw new Error("Test not implemented");
+    const student = new Student();
+    student.setName("Doe");
+    assert.strictEqual(student.name, "Doe", "setName should correctly set the student's name");
+    student.setName(123); 
+    assert.strictEqual(student.name, "Doe", "setName should not set name when the input is not a string");
 });
 
 test("Test Student's getName", () => {
-    // TODO
-    throw new Error("Test not implemented");
-});
+    const student = new Student();
+    student.setName("Smith");
+    assert.strictEqual(student.getName(), "Smith", "getName should return the correct name");
+    const newStudent = new Student();
+    assert.strictEqual(newStudent.getName(), '', "getName should return an empty string for a student without a name");
+});

lab5/Answer.md

@@ -1,21 +1,35 @@
 # Answer
 
+
 Name: 楊杰峰
 ID: 510558017
 
+Name: 
+ID: 
+
+
 ## Test Valgrind and ASan
 ### Result
 |                      | Valgrind | Asan |
 | -------------------- | -------- | ---- |
+
 | Heap out-of-bounds   | Yes      | Yes  |
 | Stack out-of-bounds  | Yes      | Yes  |
 | Global out-of-bounds | Yes      | Yes  |
 | Use-after-free       | Yes      | Yes  |
 | Use-after-return     | Yes      | Yes  |
 
+| Heap out-of-bounds   |          |      |
+| Stack out-of-bounds  |          |      |
+| Global out-of-bounds |          |      |
+| Use-after-free       |          |      |
+| Use-after-return     |          |      |
+
+
 ### Heap out-of-bounds
 #### Source code
 ```
+
 #include <stdio.h>
 #include <stdlib.h>
 
@@ -31,6 +45,7 @@ int main() {
     return 0;
 }
 
+
 ```
 #### Valgrind Report
 ```
@@ -52,7 +67,6 @@ int main() {
 ```
 ### ASan Report
 ```
-=================================================================
 ==10519==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x603000000024 at pc 0x56433e0122a2 bp 0x7ffcb47c35e0 sp 0x7ffcb47c35d0
 WRITE of size 4 at 0x603000000024 thread T0
     #0 0x56433e0122a1 in heap_out_of_bounds (/home/jf/510558017/510558017/lab5/heap_out_of_bounds+0x12a1)
@@ -101,6 +115,12 @@ Shadow byte legend (one shadow byte represents 8 application bytes):
   Right alloca redzone:    cb
   Shadow gap:              cc
 ==10519==ABORTING
+
+```
+### ASan Report
+```
+
+
 ```
 
 ### Stack out-of-bounds
@@ -119,6 +139,7 @@ int main() {
     return 0;
 }
 
+
 ```
 #### Valgrind Report
 ```
@@ -140,7 +161,6 @@ valgrind: ./stack_out_of_bounds: No such file or directory==10523== Memcheck, a
 ```
 ### ASan Report
 ```
-=================================================================
 ==10522==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffe0476bb84 at pc 0x563a4ff0a31c bp 0x7ffe0476bb40 sp 0x7ffe0476bb30
 WRITE of size 4 at 0x7ffe0476bb84 thread T0
     #0 0x563a4ff0a31b in stack_out_of_bounds (/home/jf/510558017/510558017/lab5/stack_out_of_bounds+0x131b)
@@ -189,6 +209,12 @@ Shadow byte legend (one shadow byte represents 8 application bytes):
   Right alloca redzone:    cb
   Shadow gap:              cc
 ==10522==ABORTING
+
+
+```
+### ASan Report
+```
+
 ```
 
 ### Global out-of-bounds
@@ -208,6 +234,7 @@ int main() {
     return 0;
 }
 
+
 ```
 #### Valgrind Report
 ```
@@ -230,7 +257,6 @@ int main() {
 ### ASan Report
 ```
 AddressSanitizer:DEADLYSIGNAL
-=================================================================
 ==4271==ERROR: AddressSanitizer: SEGV on unknown address 0x55f0360a2010 (pc 0x55f03609e223 bp 0x7ffccdefbd80 sp 0x7ffccdefbd80 T0)
 ==4271==The signal is caused by a WRITE memory access.
     #0 0x55f03609e222 in global_out_of_bounds (/home/jf/510558017/510558017/lab5/global_out_of_bounds+0x1222)
@@ -241,6 +267,12 @@ AddressSanitizer:DEADLYSIGNAL
 AddressSanitizer can not provide additional info.
 SUMMARY: AddressSanitizer: SEGV (/home/jf/510558017/510558017/lab5/global_out_of_bounds+0x1222) in global_out_of_bounds
 ==4271==ABORTING
+
+
+```
+### ASan Report
+```
+
 ```
 
 ### Use-after-free
@@ -261,6 +293,7 @@ int main() {
     return 0;
 }
 
+
 ```
 #### Valgrind Report
 ```
@@ -337,6 +370,12 @@ Shadow byte legend (one shadow byte represents 8 application bytes):
   Right alloca redzone:    cb
   Shadow gap:              cc
 ==11127==ABORTING: No such file or directory
+
+
+```
+### ASan Report
+```
+
 ```
 
 ### Use-after-return
@@ -359,6 +398,7 @@ int main() {
     return 0;
 }
 
+
 ```
 #### Valgrind Report
 ```
@@ -381,7 +421,6 @@ int main() {
 ### ASan Report
 ```
 AddressSanitizer:DEADLYSIGNAL
-=================================================================
 ==11129==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x55c39c7c93ac bp 0x7fffe81607a0 sp 0x7fffe8160790 T0)
 ==11129==The signal is caused by a READ memory access.
 ==11129==Hint: address points to the zero page.
@@ -393,6 +432,12 @@ AddressSanitizer:DEADLYSIGNAL
 AddressSanitizer can not provide additional info.
 SUMMARY: AddressSanitizer: SEGV (/home/jf/510558017/510558017/lab5/use_after_return+0x13ab) in use_after_return
 ==11129==ABORTING
+
+
+```
+### ASan Report
+```
+
 ```
 
 ## ASan Out-of-bound Write bypass Redzone
@@ -417,3 +462,8 @@ int main() {
 ```
 ### Why
 ASan 能夠偵測到剛好超出 redzone 的越界寫操作，因為它會在每個分配的內存區域前後添加 redzones，並在訪問這些區域時檢測到越界操作。
+
+
+```
+### Why
+

lab5/antiasan.c

@@ -5,4 +5,9 @@ void antiasan(unsigned long addr)
 {
     uintptr_t shadow_addr = (addr >> 3) + 0x7fff8000;
     *(volatile char *)shadow_addr = 0;
+
+// TODO:
+void antiasan(unsigned long addr)
+{
+
 }