Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of Issues in the "Review" and "Completed" lane of the SORMAS Foundation #13138

Open
4 tasks
markusmann-vg opened this issue Sep 4, 2024 · 2 comments
Open
4 tasks
Labels
task Something to be done that does not directly affect the software

Comments

@markusmann-vg
Copy link

markusmann-vg commented Sep 4, 2024

Problem Description

Several issues have recently been tagged as "Completed." Before merging them into the main branch, a thorough review is necessary.

https://github.com/orgs/SORMAS-Foundation/projects/7/views/1

Proposed Solution

The review should focus on two key areas:

  1. Impact on the Main Branch:
  • Evaluate the potential effects these changes will have on the stability, functionality, and performance of the main branch.
  • Identify any breaking changes or dependencies that may require further testing.
  1. Quality of Pull Requests:
  • Ensure that all submitted pull requests are of high quality, adhering to the project's coding standards and contribution guidelines.
  • Verify that appropriate testing has been completed, and documentation is up-to-date where applicable.

Checklist:

  • Review completed issues for any potential impact on the main branch.
  • Validate that all pull requests related to these issues follow the contribution guidelines.
  • Confirm that tests have been conducted and documentation updated as needed.
  • Identify any additional tasks necessary for a smooth merge into the main branch.

Additional Information

Please make sure to assign reviewers accordingly and provide feedback directly on the related pull requests.

Especially this issue caught my attention:
#12881 => Password reset Merge back to SORMAS main branch

[ ] Is there a feature configuration ?
[ ] Is it hidden, when keycloak is enabled?
[ ] If not, does it redirect the user to the keycloak feature of resetting the password?

...

@markusmann-vg markusmann-vg added the task Something to be done that does not directly affect the software label Sep 4, 2024
@markusmann-vg markusmann-vg changed the title Review of Completed Issues of the SORMAS Foundation Review of Issues in the "Review" and "Completed" lane of the SORMAS Foundation Sep 4, 2024
@daveotengo
Copy link

  1. Is there a feature configuration ? Yes its done now.

  2. If not, does it redirect the user to the keycloak feature of resetting the password? Yes its done now.

@daveotengo
Copy link

For authentication Provider keycloak reset password implementation has now been changed from redirect to forgot password to allow for the user enter current, new and confirm password.

Thanks
David Oteng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Something to be done that does not directly affect the software
Projects
None yet
Development

No branches or pull requests

2 participants