Integrate snews-data-formats into snews-cs #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mns to match snews-data-formats
Other package minor version updates are included.
Update requirements.txt to incorporate hop-client v0.10
Format checker will bypass the detector name check if it's a test-connection command type
Support test connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nov 18, 2024: This currently incorporates snews-data-formats in the most minimal way possible.
There are still improvements that we will want to implement to make the code more readable and robust. For example, currently, snews_cs still passes messages into its own format checker class, which is unnecessary. Eventually we will want to eliminate that format checker entirely.
With this PR, snews_cs now expects to receive messages with binary blob contents from the kafka topic, rather than json blob contents. The binary blob contains the full snews message object as defined by snews-data-formats. Each snews message object is then passed throughout the system just as before.
Some message field names have changed. For example,
_idis nowid, times such asneutrino_timeare nowneutrino_time_utc, andt_bin_widthis nowt_bin_width_sec.Resolves #132, #102