Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colours in DOS #208

Open
brlec opened this issue May 23, 2023 · 3 comments · May be fixed by #209
Open

Colours in DOS #208

brlec opened this issue May 23, 2023 · 3 comments · May be fixed by #209

Comments

@brlec
Copy link

brlec commented May 23, 2023

Hi guys,
Would it be possible to either remove the defaults in sumo/plotting/orbital_colours.conf or change them so that O, S and Se aren't all the same green for the p orbitals? Very minor but it's really annoying to have to make the conf files when you just want to quickly check a DOS
Thanks!
@utf
Copy link
Member

utf commented May 23, 2023

Sure, submit a PR. Happy for you to remove them from the config.

@brlec
Copy link
Author

brlec commented May 23, 2023

think it worked?

@ajjackson ajjackson linked a pull request May 25, 2023 that will close this issue
Open
@ajjackson
Copy link
Member

Hmm, I thought I'd posted a comment here already! Maybe I got distracted before it was done, that happens at lot at the moment...

This change will probably cause unpleasant surprises for some users who don't expect their plotting colour scheme to change! If the current problems are:

  • it is a nuisance to set colours in the directory or to explicitly pass a config file, when the user has a simple and consistent preference
  • there is no way to disable the default colours

Then I suggest a "non-destructive" alternative that could solve both problems:

  • look for a user config file somewhere like ~/.config/sumo/dos-colors.conf
  • The priority order is --conf > user config > defaults
  • An empty (but existing) user file will override any default colours; if users want to tweak the stock colours they should start with a copy of the defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove colours brlec/sumo
3 participants
@utf @ajjackson @brlec