Bug in dydt for cv_avg

[mgoodson-cvd]

Just a warning to anyone still using this: there is a bug in dydt.c in the function computing cv_avg, here.

pyJac/pyjac/core/rate_subs.py

Line 2431 in 5f54b2d

line += '(' + utils.get_array(lang, 'cv', len(specs) - 1) + ' * y_N)'

There needs to be a "+" sign prior to opening the next parentheses, otherwise you end up with code that looks like this:

  double cv_avg = (cv[0] * y[1]) + (cv[1] * y[2]) + (cv[2] * y[3]) + (cv[3] * y[4])(cv[4] * y_N);

[skyreflectedinmirrors]

Heh, you can see we fixed it for conp here:

pyJac/pyjac/core/rate_subs.py

Line 2281 in 5f54b2d

if not isfirst: line += ' + '

[skyreflectedinmirrors]

I think this should do it? #44

I haven't run this in awhile, so if you test it and it looks good, let me know and I'll merge it in.

[mgoodson-cvd]

@arghdos Yes, that fixed it! Thanks for the quick response.

Once I fixed that, the compiler found another bug here:

pyJac/pyjac/core/rate_subs.py

Line 2362 in 5f54b2d

'rho, &' + (utils.get_array(lang, 'y', 1) if lang != 'cuda'

There should be a comma before the rho so that the call the eval_conc_rho is correct. After I made that change manually, it compiled!